Merge pull request #19 from hashicorp/empty-key-checks

Check empty keys during write
hashicorp · Nov 6, 2018 · 2236f14 · 2236f14
2 parents 25c9e7d + b35b8d5
commit 2236f14
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/path_data.go b/path_data.go
@@ -165,6 +165,9 @@ func (b *versionedKVBackend) pathDataRead() framework.OperationFunc {
 func (b *versionedKVBackend) pathDataWrite() framework.OperationFunc {
 	return func(ctx context.Context, req *logical.Request, data *framework.FieldData) (*logical.Response, error) {
 		key := data.Get("path").(string)
+		if key == "" {
+			return logical.ErrorResponse("missing path"), nil
+		}
 
 		config, err := b.config(ctx, req.Storage)
 		if err != nil {

diff --git a/path_metadata.go b/path_metadata.go
@@ -117,6 +117,9 @@ func (b *versionedKVBackend) pathMetadataRead() framework.OperationFunc {
 func (b *versionedKVBackend) pathMetadataWrite() framework.OperationFunc {
 	return func(ctx context.Context, req *logical.Request, data *framework.FieldData) (*logical.Response, error) {
 		key := data.Get("path").(string)
+		if key == "" {
+			return logical.ErrorResponse("missing path"), nil
+		}
 
 		maxRaw, mOk := data.GetOk("max_versions")
 		casRaw, cOk := data.GetOk("cas_required")