Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

H-2362: Support converting BaseUrl to/from Postgres #4148

Merged
merged 6 commits into from
Mar 12, 2024
Merged

H-2362: Support converting BaseUrl to/from Postgres #4148

merged 6 commits into from
Mar 12, 2024

Conversation

TimDiekmann
Copy link
Member

🌟 What is the purpose of this PR?

To allow converting a full VersionedUrl to/from Postgres the underlying BaseUrl has to be convertible. This allows a lot of simplification in queries as the types don't need to be converted to an intermediate string.

🚫 Blocked by

🔍 What does this change?

  • Move OntologyTypeVersion to type system crate
  • Implement postgres traits for BaseUrl and VersionedUrl
  • Use BaseUrl directly to convert from/to Postgres

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

@TimDiekmann TimDiekmann added the state/blocked This pull request is currently blocked label Mar 11, 2024
@github-actions github-actions bot added area/deps Relates to third-party dependencies (area) area/apps > hash* Affects HASH (a `hash-*` app) area/libs Relates to first-party libraries/crates/packages (area) type/eng > backend Owned by the @backend team area/tests New or updated tests area/tests > integration New or updated integration tests area/apps area/apps > hash-graph labels Mar 11, 2024
CiaranMn
CiaranMn previously approved these changes Mar 12, 2024
View reviewed changes
Base automatically changed from t/h-2205-support-multi-type-entities-in-the-graph to main March 12, 2024 13:21
@TimDiekmann TimDiekmann dismissed CiaranMn’s stale review March 12, 2024 13:21

The base branch was changed.

@TimDiekmann TimDiekmann force-pushed the t/h-2362-support-converting-baseurl-tofrom-postgres branch from ec62d2d to c7e9604 Compare March 12, 2024 13:35
@TimDiekmann TimDiekmann removed the state/blocked This pull request is currently blocked label Mar 12, 2024
@TimDiekmann TimDiekmann mentioned this pull request Mar 12, 2024
Merged
3 tasks
@TimDiekmann TimDiekmann added this pull request to the merge queue Mar 12, 2024
Merged via the queue into main with commit a3088eb Mar 12, 2024
111 checks passed
@TimDiekmann TimDiekmann deleted the t/h-2362-support-converting-baseurl-tofrom-postgres branch March 12, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CiaranMn CiaranMn CiaranMn approved these changes

Assignees

@TimDiekmann TimDiekmann

Labels
area/apps > hash* Affects HASH (a `hash-*` app) area/apps > hash-graph area/apps area/deps Relates to third-party dependencies (area) area/libs Relates to first-party libraries/crates/packages (area) area/tests > integration New or updated integration tests area/tests New or updated tests type/eng > backend Owned by the @backend team
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TimDiekmann @CiaranMn