Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEN-200: Set MSRV for error-stack to v1.83 #5333

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

TimDiekmann
Copy link
Member

🌟 What is the purpose of this PR?

Rust 1.83 enables a bunch of new features (we're currently on 1.63 and a lot has been added since then)

🔍 What does this change?

  • Bump MSRV to 1.83
  • Remove unneeded cfg-flags
  • Satisfy linting

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • modifies a Cargo-publishable library, but it is not yet ready to publish

📜 Does this require a change to the docs?

The changes in this PR:

  • require changes to docs which are made as part of this PR

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

🐾 Next steps

  • Remove Context in favor of core::error::Error
  • Remove once-cell in favor of std::sync::LazyLock

@TimDiekmann TimDiekmann self-assigned this Oct 7, 2024
@github-actions github-actions bot added area/infra Relates to version control, CI, CD or IaC (area) area/libs > error-stack Affects the `error-stack` crate (library) area/libs Relates to first-party libraries/crates/packages (area) area/tests New or updated tests labels Oct 7, 2024
Copy link
Contributor

github-actions bot commented Oct 7, 2024

Benchmark results

@rust/graph-benches – Integrations

representative_read_multiple_entities

Function Value Mean Flame graphs
entity_by_property depths: DT=0, PT=2, ET=2, E=2 $$55.4 \mathrm{ms} \pm 355 \mathrm{μs}\left({\color{gray}-2.903 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=2, E=2 $$51.1 \mathrm{ms} \pm 279 \mathrm{μs}\left({\color{gray}-3.320 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=2 $$44.0 \mathrm{ms} \pm 273 \mathrm{μs}\left({\color{gray}-2.357 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=255, PT=255, ET=255, E=255 $$68.7 \mathrm{ms} \pm 356 \mathrm{μs}\left({\color{gray}-1.960 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=2, PT=2, ET=2, E=2 $$59.4 \mathrm{ms} \pm 474 \mathrm{μs}\left({\color{gray}-4.749 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=0 $$40.0 \mathrm{ms} \pm 208 \mathrm{μs}\left({\color{gray}-0.713 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=2, ET=2, E=2 $$94.7 \mathrm{ms} \pm 551 \mathrm{μs}\left({\color{gray}-4.161 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=2, E=2 $$90.2 \mathrm{ms} \pm 460 \mathrm{μs}\left({\color{gray}-4.223 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=2 $$80.2 \mathrm{ms} \pm 462 \mathrm{μs}\left({\color{gray}-4.015 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=255, PT=255, ET=255, E=255 $$108 \mathrm{ms} \pm 599 \mathrm{μs}\left({\color{gray}-2.830 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=2, PT=2, ET=2, E=2 $$98.9 \mathrm{ms} \pm 559 \mathrm{μs}\left({\color{gray}-4.148 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=0 $$42.9 \mathrm{ms} \pm 236 \mathrm{μs}\left({\color{gray}-3.952 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity

Function Value Mean Flame graphs
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/building/v/1 $$16.2 \mathrm{ms} \pm 191 \mathrm{μs}\left({\color{gray}-3.624 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/song/v/1 $$16.0 \mathrm{ms} \pm 173 \mathrm{μs}\left({\color{gray}3.35 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/page/v/2 $$15.1 \mathrm{ms} \pm 177 \mathrm{μs}\left({\color{lightgreen}-35.288 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/book/v/1 $$15.7 \mathrm{ms} \pm 193 \mathrm{μs}\left({\color{gray}-0.282 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/uk-address/v/1 $$17.1 \mathrm{ms} \pm 216 \mathrm{μs}\left({\color{gray}3.17 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/organization/v/1 $$16.3 \mathrm{ms} \pm 180 \mathrm{μs}\left({\color{lightgreen}-6.561 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/block/v/1 $$15.5 \mathrm{ms} \pm 199 \mathrm{μs}\left({\color{lightgreen}-32.026 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/playlist/v/1 $$16.3 \mathrm{ms} \pm 199 \mathrm{μs}\left({\color{red}5.17 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/person/v/1 $$16.1 \mathrm{ms} \pm 184 \mathrm{μs}\left({\color{gray}-2.906 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity_type

Function Value Mean Flame graphs
get_entity_type_by_id Account ID: d4e16033-c281-4cde-aa35-9085bf2e7579 $$1.41 \mathrm{ms} \pm 6.86 \mathrm{μs}\left({\color{gray}0.282 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_zero_depth

Function Value Mean Flame graphs
entity_by_id 10 entities $$2.00 \mathrm{ms} \pm 12.0 \mathrm{μs}\left({\color{gray}-3.103 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 25 entities $$2.48 \mathrm{ms} \pm 8.23 \mathrm{μs}\left({\color{lightgreen}-18.507 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$1.90 \mathrm{ms} \pm 9.52 \mathrm{μs}\left({\color{gray}-1.428 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 50 entities $$4.08 \mathrm{ms} \pm 24.7 \mathrm{μs}\left({\color{gray}2.32 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$1.87 \mathrm{ms} \pm 9.99 \mathrm{μs}\left({\color{gray}-1.908 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_one_depth

Function Value Mean Flame graphs
entity_by_id 10 entities $$51.2 \mathrm{ms} \pm 220 \mathrm{μs}\left({\color{red}63.0 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 25 entities $$73.7 \mathrm{ms} \pm 509 \mathrm{μs}\left({\color{gray}-0.021 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$24.8 \mathrm{ms} \pm 95.9 \mathrm{μs}\left({\color{gray}-1.632 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 50 entities $$275 \mathrm{ms} \pm 2.18 \mathrm{ms}\left({\color{lightgreen}-32.120 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$19.9 \mathrm{ms} \pm 86.4 \mathrm{μs}\left({\color{gray}-0.211 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_linkless

Function Value Mean Flame graphs
entity_by_id 10000 entities $$9.61 \mathrm{ms} \pm 162 \mathrm{μs}\left({\color{lightgreen}-22.130 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$1.87 \mathrm{ms} \pm 6.49 \mathrm{μs}\left({\color{gray}-0.840 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 100 entities $$2.03 \mathrm{ms} \pm 8.47 \mathrm{μs}\left({\color{gray}1.43 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1000 entities $$2.70 \mathrm{ms} \pm 17.8 \mathrm{μs}\left({\color{gray}-3.691 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$1.86 \mathrm{ms} \pm 5.85 \mathrm{μs}\left({\color{gray}0.012 \mathrm{\%}}\right) $$ Flame Graph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra Relates to version control, CI, CD or IaC (area) area/libs > error-stack Affects the `error-stack` crate (library) area/libs Relates to first-party libraries/crates/packages (area) area/tests New or updated tests
Development

Successfully merging this pull request may close these issues.

1 participant