Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use latest doctest by default #690

Closed
andreasabel opened this issue Nov 23, 2023 · 3 comments · Fixed by #692
Closed

Use latest doctest by default #690

andreasabel opened this issue Nov 23, 2023 · 3 comments · Fixed by #692

Comments

@andreasabel
Copy link
Contributor

I suggest to remove the default constraint on doctest so that always the latest version gets installed unless the user asks for a specific version.

haskell-ci/src/HaskellCI/Config/Doctest.hs

Lines 28 to 29 in e0dd023

defaultDoctestVersion :: VersionRange
defaultDoctestVersion = majorBoundVersion (mkVersion [0,21,0])

doctest has seen frequent major releases recently, and the current bound is already outdated. Even if updated, it will rot quickly.
@andreasabel andreasabel mentioned this issue Nov 23, 2023
Closed
andreasabel added a commit to andreasabel/haskell-ci that referenced this issue Nov 23, 2023
@andreasabel
By default, do not constrain doctest
bb29833 
`doctest` bound has been rotting too quickly.
Just use the latest version by default.
Can always be overwritting by `doctest-version` option in `cabal.haskell-ci`.

Closes haskell-CI#690
@phadej
Copy link
Collaborator

phadej commented Nov 23, 2023

The latest doctest should be "standalone" run as cabal repl --with-ghc=doctest, as I'm not using doctest myself anymore, I haven't made according changes to the CI generation either.

@andreasabel
Copy link
Contributor Author

@phadej locked the conversation on #691.

Apologies, but I don't suffer to be muzzled.

@phadej wrote:

as I'm not using doctest myself anymore, I haven't made according changes to the CI generation either.

From the interaction in #691 and from accumulated interactions on various other PRs, I am getting the impression that you consider haskell-ci as your private tool rather than trying to maximise its usability for the greater Haskell community.

I don't see how this continues Herbert's legacy.

I am beginning to believe our interaction on this project cannot be healed. You do not seem to want any collaboration.

@phadej phadej mentioned this issue Dec 3, 2023
Merged
@phadej
Copy link
Collaborator

phadej commented Dec 3, 2023

I have been working on this tool for six years, and already mostly rewritten it when Herbert were still around as the graphs show https://github.com/haskell-CI/haskell-ci/graphs/contributors, so please don't bring Herbert into this.

I am beginning to believe our interaction on this project cannot be healed.

You seem to think that all your ideas and requests need or must be implemented.

Some are good, but many are not. You are not right all the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@phadej @andreasabel