Adding ability to specify mulitple postgresql versions to be used in builds #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arybczak
reviewed
Sep 9, 2022
| let postgresVersions = if cfgPostgres | ||
| then Just <$> cfgPostgresVersions | ||
| else [Nothing] | ||
| for_ (reverse $ S.toList linuxVersions) $ \v -> |
There was a problem hiding this comment.
This can be toDescList. Same below.
|
@phadej could this be merged? I wanted to add an option to configure PostgreSQL version used (since right now 10 is hardcoded), but this is much better. |
|
@phadej are you interested in merging this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds a new parameter
postgresql-versionsthat one can use to specify more than one postgresql version that is later used in matrix. I didn't remove thepostgresqlflag to not break the backward compability.