Use HLint 3.6.1

[phadej]

No description provided.

[RyanGlScott]

One thing that I discovered when trying out the hlint-3.6.1 bindist is that dynamically links against the glibc version provided by Ubuntu 22.04 (Jammy). This will not work if you run hlint-3.6.1 on Ubuntu 20.04 (Bionic), which is the default setting for haskell-ci. An example of this failing:

hlint: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by hlint)
hlint: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.29' not found (required by hlint)

I'm not sure if there is a good way to handle this on the haskell-ci side. Perhaps a disclaimer in the documentation somewhere?

[phadej]

Thanks for bringing that up!

I'm not sure if there is a good way to handle this on the haskell-ci side.

There isn't.

Perhaps a disclaimer in the documentation somewhere?

Nobody reads docs, until there is problem, then they google and will find this issue.

---

I opened an upstream issue: ndmitchell/hlint#1533, and will withhold merging this PR until the upstream issue is resolved in a way or another.

[marinelli]

It's possible to specify, for a particular GitHub Job, a different image [1]. So you could use the ubuntu:20.04 image by default, but for the linting jobs the ubuntu:22.04 one.
Anyway, I agree that a statically linked binary is a much more resilient solution.

[1] https://docs.github.com/en/actions/using-jobs/running-jobs-in-a-container

[RyanGlScott]

This is likely obsolete after #717.