coercion to NixString; iterNValue': flip 1st arg; unflip runFreshIdT #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now there are no uses of `coerceToString` in the codebase.
As deleted WTF note states - the set processing was in the "Stringy" block. Decomposition shown the proper place and tied togather mutual recursion in the case of a set.
Not needed as functions internally already do it.
`M` suffix for it, as there is `nest` without monad.
M src/Nix/Value.hs
Code points out it clearly. Additionally, if people are accustomed to Reader monad & runReader - keep it that way.
Anton-Latukha
force-pushed
the
2021-10-31-upd-coerceToNixString
branch
from
8819a0d
to
2a38563
Compare
Anton-Latukha
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is interesting in
Utils&Valuewhere things were updated to fixpoint combinators.Which, if internally laziness is preserved - running the function & apply the argument to it only once & optimize during compilation.
In Haskell Core I found that
fixsometimes roughly converts just tolet x = f x in x(stays a basiclet,letrecin terms of Core language).So far I can not reason beyond Core, it is hard to say how
letreccompiles.This is a work I did before the
Nix 2.4release, which broke the CI on all fronts. I decided to not run putting created by upstream fires. Decided to not overcomplicate the Git processes for myself, so decided to finish & contribute the work first & then go do fix things.