Upd {{Value, Eval Provenance, JSON} builders, Option getters, Utils} #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M src/Nix/Json.hs
To make them readable in code & entail at least some meaning.
Anton-Latukha
changed the title
This allows to slash the converstion code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/haskell-nix/hnix/wiki/Naming-style-guidelines
Closes a lot of #949
Option getter names are not ideal (I can not name them properly currently because every one of them requires in-depth lookup of what was the semantic meanings implied but not expressed, as it was not documented, to name them a superset of them must be considered. And strangely, at least a couple of them, based on the code, - are redundant, a synonym of one another. But current naming is than before & push thoughts into the right direction.