Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile on GHC 9.4.3 #1081

Merged
merged 2 commits into from
Nov 17, 2022
Merged

Compile on GHC 9.4.3 #1081

merged 2 commits into from
Nov 17, 2022

Conversation

alex-mckenna
Copy link
Contributor

This PR bumps dependency bounds and makes small fixes to allow hnix to build with GHC 9.4.3.

@alex-mckenna
Copy link
Contributor Author

Trying it out locally, I can also build with no problems on GHC 9.2.4 after this patch.

I see neither versions are included in CI. Would you like me to add 9.2 and 9.4 to the GitHub CI? I don't know if testing double the number of versions of GHC that are tested currently would make CI too slow for comfort or not.

@sjakobi
Copy link
Member

sjakobi commented Nov 16, 2022

Yes, CI with 9.2 and 9.4 would be great to have. If adding both causes problems, my preference would be to add CI with just 9.4.

@alex-mckenna
Copy link
Contributor Author

I've added the GHC versions to CI, I wasn't sure from looking if the other workflows needed any changes.

In the process I noticed that although I didn't bump the version for time, everything built without it (even though time is a boot library). This seemed... odd, so I also bumped time to the bounds the release notes for 9.4.3 suggest.

sjakobi
sjakobi reviewed Nov 17, 2022
View reviewed changes
Copy link
Member

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to do something about the new warnings that have popped up with 9.2 and 9.4. Disabling -Wincomplete-uni-patterns seems fine to me.

hnix.cabal Outdated Show resolved Hide resolved
@sjakobi sjakobi merged commit b89eed9 into haskell-nix:master Nov 17, 2022
@sjakobi
Copy link
Member

sjakobi commented Nov 17, 2022

Thanks a lot, @alex-mckenna! :)

@sjakobi sjakobi mentioned this pull request Nov 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjakobi sjakobi sjakobi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alex-mckenna @sjakobi