Add builtins.split #154
Closed
Add builtins.split #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing commit fails to build on my machine.
Finishes issue haskell-nix#113
|
I'd like to avoid a dependency on |
|
Actually, never mind that, they don't have an implementation of |
|
@mightybyte Is this close to being ready? |
|
The split implementation is ready but it's still not passing yet because there's one test that includes an indented string and that's not working yet. |
|
Ah, since there's already an issue for that, we shouldn't hold up your split work. The scope of the PR just needs to be narrowed down to just the changes needed for split. |
|
Ok, then this should be ready. It still won't pass the test case unless you comment out the one with the indented text. |
|
Merged by hand. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.