Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix wrong markdowntype javascript for json #1389

Merged
merged 1 commit into from
Apr 30, 2024
Merged

fix wrong markdowntype javascript for json #1389

merged 1 commit into from
Apr 30, 2024

Conversation

vismaya-kalyan
Copy link
Contributor

This PR fixes servant-docs: Wrong markdowntype javascript for json
#1358

fisx
fisx previously approved these changes Jan 23, 2021
View reviewed changes
@fisx
Copy link
Member

fisx commented Jan 23, 2021

the changes look fine to me, but it looks like there are golden tests that need adjusting, but i have no idea why this only happens for some ghc versions. could you take another look?

@fisx fisx self-requested a review January 23, 2021 08:35
@fisx fisx dismissed their stale review January 23, 2021 08:35

i think test failures need work, or at least explaining

@vismaya-kalyan
Copy link
Contributor Author

vismaya-kalyan commented Jan 23, 2021 •
edited
Loading

the changes look fine to me, but it looks like there are golden tests that need adjusting, but i have no idea why this only happens for some ghc versions. could you take another look?

Sure, I'll try and figure it out. Thanks!

@akhesaCaro
Copy link
Contributor

Hi vismaya-kalyan

Thanks for your contribution. The CI has been fixed, could you rebase your branch to see if it passes the CI checks?

@vismaya-kalyan
Copy link
Contributor Author

Thanks for your contribution. The CI has been fixed, could you rebase your branch to see if it passes the CI checks?

This looks better but it fails on stack/ghc 8.8.4 on the same test as last time:(

@tchoutri tchoutri merged commit 584dd02 into haskell-servant:master Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fisx fisx Awaiting requested review from fisx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vismaya-kalyan @fisx @akhesaCaro @tchoutri