Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix intersection #421

Closed
wants to merge 3 commits into from
Closed

Fix intersection #421

wants to merge 3 commits into from

Conversation

oberblastmeister
Copy link
Contributor

Fixes #420

sjakobi
sjakobi reviewed Apr 20, 2022
View reviewed changes
Data/HashMap/Internal.hs Outdated Show resolved Hide resolved
@sjakobi
Copy link
Member

sjakobi commented Apr 20, 2022

@oberblastmeister Could you cherry-pick the regression test from #422 to this branch?

treeowl
treeowl reviewed Apr 20, 2022
View reviewed changes
Data/HashMap/Internal.hs
l <- A.read mary 0
if isLeafOrCollision l
then pure l
else BitmapIndexed bFinal <$> (A.unsafeFreeze =<< A.shrink mary len)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be clearer to explicitly shrink to 1?

@sjakobi
Copy link
Member

sjakobi commented Apr 24, 2022

Thanks, @oberblastmeister. I'll finish this myself in #427.

@sjakobi sjakobi closed this Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treeowl treeowl treeowl left review comments

@sjakobi sjakobi sjakobi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Weird level-deletion in intersectionArrayBy
3 participants
@oberblastmeister @sjakobi @treeowl