Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Increase variation in generated tree shapes #442

Merged
merged 17 commits into from
Apr 27, 2022

Conversation

sjakobi
Copy link
Member

@sjakobi sjakobi commented Apr 25, 2022

Addresses #438.


TODO:

  • Use the same Key type for HashSet and Strictness tests
  • Try producing Full nodes?!
  • Check that any tests that use specific colliding keys still do the right thing.
  • Improve shrinking for SmallSum (shrinkBoundedEnum?!  nick8325/quickcheck#343)

@sjakobi
Copy link
Member Author

sjakobi commented Apr 26, 2022

[ ] Try producing Full nodes?!

I think this might be a bit tricky. I don't think we can achieve this by tweaking the Key generator. I think we'd have to tweak the [(Key,X)] inputs for the property tests, which are currently using the default Arbitrary [] instance.

@sjakobi sjakobi mentioned this pull request Apr 26, 2022
3 tasks
@sjakobi sjakobi marked this pull request as ready for review April 27, 2022 13:43
@sjakobi
Copy link
Member Author

sjakobi commented Apr 27, 2022

[ ] Try producing Full nodes?!

I think this might be a bit tricky. I don't think we can achieve this by tweaking the Key generator. I think we'd have to tweak the [(Key,X)] inputs for the property tests, which are currently using the default Arbitrary [] instance.

I'll leave this for future work. Ideally we can solve this by removing the Full constructor (#399).

@sjakobi sjakobi merged commit 0bbbac1 into master Apr 27, 2022
@sjakobi sjakobi deleted the sjakobi/438-generated-trees branch April 27, 2022 15:30
@sjakobi
Copy link
Member Author

sjakobi commented Apr 27, 2022

[ ] Try producing Full nodes?!

I think this might be a bit tricky. I don't think we can achieve this by tweaking the Key generator. I think we'd have to tweak the [(Key,X)] inputs for the property tests, which are currently using the default Arbitrary [] instance.

I'll leave this for future work. Ideally we can solve this by removing the Full constructor (#399).

Tracked in #445.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant