Skip to content

Commit

Permalink
Merge pull request #6857 from TomMD/fix/make-warning-red-so-people-re…
Browse files Browse the repository at this point in the history
…ad-and-i-do-not-start-seeing-red

Fix #6856 Make `--lib` warning louder and clearer
  • Loading branch information
phadej authored Jun 4, 2020
2 parents 48a8dfa + 2071398 commit 07c1a43
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 4 deletions.
12 changes: 8 additions & 4 deletions cabal-install/Distribution/Client/CmdInstall.hs
Original file line number Diff line number Diff line change
Expand Up @@ -678,10 +678,14 @@ warnIfNoExes :: Verbosity -> ProjectBuildContext -> IO ()
warnIfNoExes verbosity buildCtx =
when noExes $
warn verbosity $
"You asked to install executables, but there are no executables in "
<> plural (listPlural selectors) "target" "targets" <> ": "
<> intercalate ", " (showTargetSelector <$> selectors) <> ". "
<> "Perhaps you want to use --lib to install libraries instead."
"\n" <>
"@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@\n" <>
"@ WARNING: Installation might not be completed as desired! @\n" <>
"@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@\n" <>
"Without flags, the command \"cabal install\" doesn't expose" <>
" libraries in a usable manner. You might have wanted to run" <>
" \"cabal install --lib " <>
unwords (showTargetSelector <$> selectors) <> "\". "
where
targets = concat $ Map.elems $ targetsMap buildCtx
components = fst <$> targets
Expand Down
4 changes: 4 additions & 0 deletions changelog.d/issue-6856
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
synopsis: Adjust message indicating `--lib` is likely desired
packages: cabal-install
issues: #6856
prs: #6857

0 comments on commit 07c1a43

Please sign in to comment.