Skip to content

Commit

Permalink
Merge pull request #6541 from phadej/accept-any-modversion
Browse files Browse the repository at this point in the history
Accept any pkg-config --modversion output
  • Loading branch information
phadej authored Feb 14, 2020
2 parents b744cde + cf67129 commit 3e05a15
Showing 1 changed file with 7 additions and 8 deletions.
15 changes: 7 additions & 8 deletions Cabal/Distribution/Simple/Configure.hs
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ import Distribution.Simple.BuildTarget
import Distribution.Simple.LocalBuildInfo
import Distribution.Types.ExeDependency
import Distribution.Types.LegacyExeDependency
import Distribution.Types.PkgconfigVersion
import Distribution.Types.PkgconfigDependency
import Distribution.Types.PkgconfigVersionRange
import Distribution.Types.LocalBuildInfo
Expand Down Expand Up @@ -119,7 +120,7 @@ import Data.ByteString.Lazy ( ByteString )
import qualified Data.ByteString as BS
import qualified Data.ByteString.Lazy.Char8 as BLC8
import Data.List
( (\\), partition, inits, stripPrefix, intersect )
( (\\), partition, inits, stripPrefix, intersect, dropWhileEnd )
import Data.Either
( partitionEithers )
import qualified Data.Map as Map
Expand Down Expand Up @@ -1616,13 +1617,11 @@ configurePkgconfigPackages verbosity pkg_descr progdb enabled
version <- pkgconfig ["--modversion", pkg]
`catchIO` (\_ -> die' verbosity notFound)
`catchExit` (\_ -> die' verbosity notFound)
case simpleParsec version of
Nothing -> die' verbosity
"parsing output of pkg-config --modversion failed"
Just v | not (withinPkgconfigVersionRange v range) ->
die' verbosity (badVersion v)
| otherwise ->
info verbosity (depSatisfied v)
let trim = dropWhile isSpace . dropWhileEnd isSpace
let v = PkgconfigVersion (toUTF8BS $ trim version)
if not (withinPkgconfigVersionRange v range)
then die' verbosity (badVersion v)
else info verbosity (depSatisfied v)
where
notFound = "The pkg-config package '" ++ pkg ++ "'"
++ versionRequirement
Expand Down

0 comments on commit 3e05a15

Please sign in to comment.