Skip to content

Commit

Permalink
After moving GHC 9.4.2->9.4.4 some broken Windows tests work
Browse files Browse the repository at this point in the history
Partially revert 78cbeba.
  • Loading branch information
ulysses4ever committed Apr 3, 2023
1 parent 2e8a1e1 commit 420ccd8
Show file tree
Hide file tree
Showing 14 changed files with 0 additions and 42 deletions.
3 changes: 0 additions & 3 deletions cabal-testsuite/PackageTests/CustomPreProcess/cabal.test.hs
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
import Test.Cabal.Prelude
-- Test internal custom preprocessor
main = cabalTest $ do
isWin <- isWindows
ghc94 <- isGhcVersion "== 9.4.*"
expectBrokenIf (isWin && ghc94) 8451 $ do
skipUnless "no Cabal for GHC" =<< hasCabalForGhc

-- old Cabal's ./Setup.hs output is difficult to normalise
Expand Down
3 changes: 0 additions & 3 deletions cabal-testsuite/PackageTests/FFI/ForeignOptsC/cabal.test.hs
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
import Test.Cabal.Prelude
main = cabalTest $ do
isWin <- isWindows
ghc94 <- isGhcVersion "== 9.4.*"
expectBrokenIf (isWin && ghc94) 8451 $ do
cabal "v2-build" ["foreign-opts-c-exe"]
withPlan $ runPlanExe "foreign-opts-c" "foreign-opts-c-exe" []
3 changes: 0 additions & 3 deletions cabal-testsuite/PackageTests/FFI/ForeignOptsCxx/cabal.test.hs
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
import Test.Cabal.Prelude
main = cabalTest $ do
isWin <- isWindows
ghc94 <- isGhcVersion "== 9.4.*"
expectBrokenIf (isWin && ghc94) 8451 $ do
cabal "v2-build" ["foreign-opts-cxx-exe"]
withPlan $ runPlanExe "foreign-opts-cxx" "foreign-opts-cxx-exe" []
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
import Test.Cabal.Prelude

main = cabalTest $ do
isWin <- isWindows
ghc94 <- isGhcVersion "== 9.4.*"
expectBrokenIf (isWin && ghc94) 8451 $ do
cabal "v2-bench"
[ "--benchmark-option=1"
, "--benchmark-options=\"2 3\""
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
import Test.Cabal.Prelude

main = cabalTest . void $ do
isWin <- isWindows
ghc94 <- isGhcVersion "== 9.4.*"
expectBrokenIf (isWin && ghc94) 8451 $ do
cabal' "v2-build" ["script.hs"]

env <- getTestEnv
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
import Test.Cabal.Prelude

main = cabalTest . void $ do
isWin <- isWindows
ghc94 <- isGhcVersion "== 9.4.*"
expectBrokenIf (isWin && ghc94) 8451 $ do
cabal' "v2-build" ["script.hs"]
cabal' "v2-build" ["script.hs"]
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@ import Test.Cabal.Prelude
import System.Directory (copyFile, removeFile)

main = cabalTest . void $ do
isWin <- isWindows
ghc94 <- isGhcVersion "== 9.4.*"
expectBrokenIf (isWin && ghc94) 8451 $ do
env <- getTestEnv
let td = testCurrentDir env

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@ import Test.Cabal.Prelude
import System.Directory (copyFile, removeFile)

main = cabalTest . void $ do
isWin <- isWindows
ghc94 <- isGhcVersion "== 9.4.*"
expectBrokenIf (isWin && ghc94) 8451 $ do
env <- getTestEnv
let td = testCurrentDir env

Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
import Test.Cabal.Prelude

main = cabalTest . void $ do
isWin <- isWindows
ghc94 <- isGhcVersion "== 9.4.*"
expectBrokenIf (isWin && ghc94) 8451 $ do
cabal' "v2-build" ["script.hs"]
cabal' "v2-clean" ["script.hs"]

Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
import Test.Cabal.Prelude

main = cabalTest $ do
isWin <- isWindows
ghc94 <- isGhcVersion "== 9.4.*"
expectBrokenIf (isWin && ghc94) 8451 $ do
res <- cabal' "v2-run" ["script.hs"]
assertOutputContains "Hello World" res

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
import Test.Cabal.Prelude

main = cabalTest . void $ do
isWin <- isWindows
ghc94 <- isGhcVersion "== 9.4.*"
expectBrokenIf (isWin && ghc94) 8451 $ do
cabal' "v2-run" ["with sp"] >>= assertOutputContains "Hello World"
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
import Test.Cabal.Prelude

main = cabalTest . void $ do
isWin <- isWindows
ghc94 <- isGhcVersion "== 9.4.*"
expectBrokenIf (isWin && ghc94) 8451 $ do
cabal' "v2-run" ["script.hs"]
cabal' "v2-run" ["script.hs"]
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
import Test.Cabal.Prelude

main = cabalTest $ do
isWin <- isWindows
ghc94 <- isGhcVersion "== 9.4.*"
expectBrokenIf (isWin && ghc94) 8451 $ do
-- script is called "s.hs" to avoid Windows long path issue in CI
res <- cabal' "v2-run" ["s.hs"]
assertOutputContains "Hello World" res
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
import Test.Cabal.Prelude

main = cabalTest $ do
isWin <- isWindows
ghc94 <- isGhcVersion "== 9.4.*"
expectBrokenIf (isWin && ghc94) 8451 $ do
cabal "v2-test"
[ "--test-option=1"
, "--test-options=\"2 3\""
Expand Down

0 comments on commit 420ccd8

Please sign in to comment.