Filter CommonSetupFlags more consistently in UnpackedPackage
#10395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In haskell#10292, we will move the `--keep-temp-files` setting into `CommonSetupFlags` and out of `ReplFlags`/`HaddockFlags`. This means that the flag-filtering behavior (which adapts flags from new versions of `cabal-install` to old version of `Cabal`) will need to know which command is being run to provide the correct `CommonSetupFlags`. Therefore, this change adds several new `filterFooFlags` functions to provide this behavior, and removes the `commonFlags` used for all subcommands in `Distribution.Client.ProjectBuilding.UnpackedPackage`.
5 tasks
mpickering
approved these changes
Sep 30, 2024
|
LGTM. |
mergify
bot
added
merge delay passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off of #10292.
In #10292, we will move the
--keep-temp-filessetting intoCommonSetupFlagsand out ofReplFlags/HaddockFlags. This means that the flag-filtering behavior (which adapts flags from new versions ofcabal-installto old version ofCabal) will need to know which command is being run to provide the correctCommonSetupFlags.Therefore, this change adds several new
filterFooFlagsfunctions to provide this behavior, and removes thecommonFlagsused for all subcommands inDistribution.Client.ProjectBuilding.UnpackedPackage.