Remove support for .zip format source distributions
#5755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typedrat
approved these changes
Dec 1, 2018
| @@ -333,7 +333,6 @@ executable cabal | |||
| zlib >= 0.5.3 && < 0.7, | |||
| hackage-security >= 0.5.2.2 && < 0.6, | |||
| text >= 1.2.3 && < 1.3, | |||
| zip-archive >= 0.3.2.5 && < 0.4, | |||
There was a problem hiding this comment.
That was fast! Will do @ both your comments
emilypi
changed the title
.zip format source distributions.zip format source distributions
|
@typedrat all fixed up! |
hvr
requested changes
Dec 1, 2018
|
Sure, let's drop the flag altogether. |
|
@hvr Excavation complete 😄 |
|
@emilypi Feel free to merge. |
|
Thanks @23Skidoo! |
|
Does merge broke appveyor CI? I see same error in my branch, as this failed. |
|
Looks like it did:
where the test is expecting |
|
That ain't good. I think I see where, and I'll post a fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #5735, including the removal of the
zip-archivedependency per the comments[ci skip]is used to avoid triggering the build bots.Extra: