Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy executables by default on windows. #6506

Closed
wants to merge 1 commit into from

Conversation

AndreasPK
Copy link
Contributor


Please include the following checklist in your PR:

  • [ x] Patches conform to the coding conventions.
  • [ x] Any changes that could be relevant to users have been recorded in the changelog.
  • [ x] The documentation has been updated, if necessary.
  • [ x] If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

Please also shortly describe how you tested your change. Bonus points for added tests!

Running cabal install on windows.

@AndreasPK
Copy link
Contributor Author

CI error seems unrelated to the patch as far as I can tell.

@AndreasPK AndreasPK requested a review from phadej January 29, 2020 22:15
@phadej
Copy link
Collaborator

phadej commented Jan 30, 2020

I'll take over this. I'd add a auto mode, which would behave as copy on windows and symlinks everywhere else, that's so you could configure explicitly the default behavior.

Later that can be extended so windows mode could symlink if that's possible (pending @Mistuke's advice on how to recognize that).

I'll also fix the changelog, but first have to try to fix that failing test, as it fails way too often.

@phadej phadej self-assigned this Jan 30, 2020
@phadej phadej mentioned this pull request Jan 31, 2020
@phadej
Copy link
Collaborator

phadej commented Feb 8, 2020

Merged as part of #6519

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants