Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show resulting executable path when running 'cabal install' #6582

Closed
wants to merge 5 commits into from
Closed

Show resulting executable path when running 'cabal install' #6582

wants to merge 5 commits into from

Conversation

emlautarom1
Copy link
Contributor

@emlautarom1 emlautarom1 commented Mar 15, 2020

Tested the changes by installing and symlinking some programs. The output looks like the discussed in #6575

Don't know where should I add the ci skip to avoid triggering a rebuild, so a maintainer should probably take a look into that


  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

@jneira
Copy link
Member

jneira commented Mar 15, 2020

LGTM! Thanks for taking care of it. 😄

Copy link
Collaborator

@phadej phadej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, otherwise looks good. Thanks!

cabal-install/Distribution/Client/CmdInstall.hs Outdated Show resolved Hide resolved
cabal-install/changelog Outdated Show resolved Hide resolved
@phadej
Copy link
Collaborator

phadej commented Mar 16, 2020

Merged squashed in #6590. Thanks!

@phadej phadej closed this Mar 16, 2020
@emlautarom1 emlautarom1 deleted the verbose-install-copy-message branch March 17, 2020 01:42
@phadej phadej mentioned this pull request Apr 1, 2020
@phadej phadej added this to the 3.4.0.0-rc1 milestone Jul 10, 2020
@phadej phadej mentioned this pull request Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants