Internal refactorings to install command. #6746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
phadej
reviewed
May 1, 2020
| @@ -628,6 +464,164 @@ installAction ( configFlags, configExFlags, installFlags | |||
| haddockFlags testFlags benchmarkFlags | |||
| globalConfigFlag = projectConfigConfigFile (projectConfigShared cliConfig) | |||
|
|
|||
|
|
|||
| getClientInstallFlags :: Verbosity -> GlobalFlags -> ClientInstallFlags -> IO ClientInstallFlags | |||
There was a problem hiding this comment.
The name should hint that this is used for ignore-project cases.
There was a problem hiding this comment.
Hmm, I'm not familiar with ignore-project cases or what they imply so can't really come up with a better name, let me know if you have a suggestion.
m-renaud
changed the title
Closed
|
Please squash into single commit and merge once CI is green |
m-renaud
force-pushed
the
m-renaud-cmd-install-refactor-installCommand
branch
from
be2a352
to
d080622
Compare
This simply extract logic out of installAction into separate helper functions. This makes the inputs to each of these explicit and removes data dependencies from a distance. This will make it easier in the future to pull out behaviour to be shared between the 'install' command and the 'env' command.
m-renaud
force-pushed
the
m-renaud-cmd-install-refactor-installCommand
branch
from
d080622
to
95d4917
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls out implementation details into standalone functions. This makes the required inputs clear and removes from-afar data dependencies.
Please include the following checklist in your PR:
changelog.ddirectory).Please also shortly describe how you tested your change. Bonus points for added tests!