Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cabal-install compilable with NoImplicitPrelude #6818

Merged
merged 1 commit into from
May 19, 2020

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented May 18, 2020

I.e. find out where we don't yet
used Distribution.Client.Compat.Prelude.

  • If the module is small I added direct Prelude imports.
  • Add Exception, deepseq stuff to Cabal Prelude
  • Add Parsec, Pretty and Verbosity to Client Prelude
  • use for, for_, traverse and traverse_ (removes need for Control.Monad)

@phadej phadej force-pushed the use-prelude-in-cli branch 4 times, most recently from 2b44384 to c6ac63d Compare May 18, 2020 21:36
I.e. find out where we don't yet
used `Distribution.Client.Compat.Prelude`.

- If the module is small I added direct `Prelude` imports.
- Add Exception, deepseq stuff to Cabal Prelude
- Add Parsec, Pretty and Verbosity to Client Prelude
- use for, for_, traverse and traverse_ (removes need for Control.Monad)
@phadej phadej merged commit 06c3eff into haskell:master May 19, 2020
@phadej phadej deleted the use-prelude-in-cli branch July 10, 2020 14:23
@phadej phadej mentioned this pull request Jul 10, 2020
@phadej phadej added this to the 3.4.0.0-rc1 milestone Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant