Tell users about cabal.project.local~ #6877
Conversation
lukel97
force-pushed
the
cabalprojectlocal-copy-message
branch
from
36991d0
to
f36b53b
Compare
| @@ -1,5 +1,5 @@ | |||
| # cabal v2-configure | |||
| 'cabal.project.local' file already exists. Now overwriting it. | |||
| 'cabal.project.local' already exists, copying it to 'cabal.project.local~'. | |||
There was a problem hiding this comment.
s/copying/backuping/.
Though I don't remember what happens when cabal.project.local~ already exists.
There was a problem hiding this comment.
It just gets overwritten it looks like
There was a problem hiding this comment.
Ok, let us fix that. Otherwise we could just overwrite cabal.project.local directly
There was a problem hiding this comment.
Fix by adding a message or by backing up cabal.project.local~ somewhere further?
lukel97
force-pushed
the
cabalprojectlocal-copy-message
branch
from
f36b53b
to
74ff63d
Compare
| @@ -95,7 +95,7 @@ configureAction flags@NixStyleFlags {..} _extraArgs globalFlags = do | |||
| -- before overwriting | |||
| exists <- doesFileExist "cabal.project.local" | |||
| when exists $ do | |||
There was a problem hiding this comment.
when exists let's search for the first one of cabal.project.local~, cabal.project.local~0 cabal.project.local~1 etc. until one doesn't.
Note: we need to change this to take into account --project-file as we on it. I wonder if there's an issue about that too.
| -- | A custom target problem | ||
| | CustomTargetProblem a |
There was a problem hiding this comment.
This was to fix a haddock failure
lukel97
force-pushed
the
cabalprojectlocal-copy-message
branch
from
55f965d
to
7357ad9
Compare
lukel97
force-pushed
the
cabalprojectlocal-copy-message
branch
from
7357ad9
to
32c6196
Compare
|
CI fails for real |
lukel97
force-pushed
the
cabalprojectlocal-copy-message
branch
from
32c6196
to
f9bf6b0
Compare
|
CI looks green now |
Please include the following checklist in your PR:
changelog.ddirectory).Please also shortly describe how you tested your change. Bonus points for added tests!