Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #6288 #6926

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Resolve #6288 #6926

merged 1 commit into from
Jun 23, 2020

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented Jun 22, 2020

  • Add availableSince to language/extension fields
    • Also autogen-modules once we are on that.
  • Remove default-language check for cabal-version: 3.4

We cannot make the field uniqueFieldAlaDef, as that would require
specifying default-language in each subconditional.
I leave it for #6925

Note: the default language is whatever is the compiler's default.
The GHC-8.10 default is its variant of Haskell2010
with NondecreasingIndentation and without DatatypeContexts


Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog (add file to changelog.d directory).
  • The documentation has been updated, if necessary.

Please also shortly describe how you tested your change. Bonus points for added tests!

- Add availableSince to language/extension fields
   - Also autogen-modules once we are on that.
- Remove default-language check for cabal-version: 3.4

We cannot make the field `uniqueFieldAlaDef`, as that would require
specifying `default-language` in each subconditional.
I leave it for haskell#6925

Note: the default language is whatever is the compiler's default.
The GHC-8.10 default is its variant of Haskell2010
with NondecreasingIndentation and without DatatypeContexts
@phadej phadej force-pushed the issue-6288-default-language branch from 57bdc6e to e42e546 Compare June 23, 2020 07:58
@phadej phadej merged commit 0538dd1 into haskell:master Jun 23, 2020
@phadej phadej deleted the issue-6288-default-language branch June 23, 2020 10:16
@phadej phadej mentioned this pull request Jul 10, 2020
@phadej phadej added this to the 3.4.0.0-rc1 milestone Jul 13, 2020
@fgaz fgaz mentioned this pull request Jan 17, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant