Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add the extension ListTuplePuns (GHC proposal 475) #8854

Merged
merged 1 commit into from
Feb 22, 2024
Merged

add the extension ListTuplePuns (GHC proposal 475) #8854

merged 1 commit into from
Feb 22, 2024

Conversation

tek
Copy link
Collaborator

@tek tek commented Mar 15, 2023

@tek tek force-pushed the torsten.schmits/add-extension-ListTuplePuns branch from 10ab83f to 897f84c Compare March 15, 2023 12:54
@ulysses4ever
Copy link
Collaborator

Thanks for the contribution!

CI fails in the usual place: you have to update that hash whenever add an extension.

@tek tek force-pushed the torsten.schmits/add-extension-ListTuplePuns branch from 897f84c to be88a1b Compare March 15, 2023 14:17
@Mikolaj
Copy link
Member

Mikolaj commented Mar 15, 2023

This time it failed to a usual GHA outage, so I've restarted failed jobs.

@Mikolaj
Copy link
Member

Mikolaj commented Jan 25, 2024

@tek: is this ready for merge? If so, could you rebase, remove the Draft mark and set the review_needed label? (Please let me know if any of these doesn't work.)

@tek tek force-pushed the torsten.schmits/add-extension-ListTuplePuns branch 2 times, most recently from 39b9a04 to 887adf3 Compare January 26, 2024 12:50
@tek
Copy link
Collaborator Author

tek commented Jan 26, 2024

the GHC MR is still not approved, though Vlad is pushing for it, so might be a few days.
I only rebased for now.

@tek tek force-pushed the torsten.schmits/add-extension-ListTuplePuns branch 3 times, most recently from cf0aed3 to 4ed2547 Compare January 26, 2024 14:25
@tek
Copy link
Collaborator Author

tek commented Jan 26, 2024

ok I guess this doesn't have to wait for the GHC MR to be merged!

@tek tek marked this pull request as ready for review January 26, 2024 14:36
@tek
Copy link
Collaborator Author

tek commented Jan 26, 2024

@Mikolaj I have no label permissions, though

@Mikolaj
Copy link
Member

Mikolaj commented Jan 26, 2024

How about now?

@tek
Copy link
Collaborator Author

tek commented Jan 26, 2024

thanks!

@tek tek force-pushed the torsten.schmits/add-extension-ListTuplePuns branch from 4ed2547 to 98e0370 Compare February 20, 2024 16:55
@tek
Copy link
Collaborator Author

tek commented Feb 20, 2024

hey @Mikolaj, would you be so kind and merge this now?

ulysses4ever
ulysses4ever approved these changes Feb 20, 2024
View reviewed changes
changelog.d/pr-8854 Outdated Show resolved Hide resolved
changelog.d/pr-8854 Outdated Show resolved Hide resolved
@tek tek force-pushed the torsten.schmits/add-extension-ListTuplePuns branch from 98e0370 to 72ceff7 Compare February 20, 2024 17:23
@ulysses4ever
Copy link
Collaborator

Feel free to proceed with the labels, as described here: https://github.com/haskell/cabal/blob/master/CONTRIBUTING.md#github-pull-request-conventions

@tek tek added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Feb 20, 2024
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Feb 22, 2024
@Mikolaj
Copy link
Member

Mikolaj commented Feb 22, 2024

@tek: apparently, a conflict with the master branch popped up at the last moment. Once you resolve it, merging should resume (probably immediately, but at worst in 2 days).

@tek tek force-pushed the torsten.schmits/add-extension-ListTuplePuns branch from 72ceff7 to 2d0d316 Compare February 22, 2024 20:38
@tek tek force-pushed the torsten.schmits/add-extension-ListTuplePuns branch from 2d0d316 to ea7f8af Compare February 22, 2024 20:50
@mergify mergify bot merged commit 9ddaa56 into haskell:master Feb 22, 2024
51 checks passed
@tek tek deleted the torsten.schmits/add-extension-ListTuplePuns branch February 22, 2024 23:05
This was referenced Mar 9, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekosaur geekosaur geekosaur approved these changes

@ulysses4ever ulysses4ever ulysses4ever approved these changes

Assignees
No one assigned
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tek @ulysses4ever @Mikolaj @geekosaur