Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI updates (drop 8.4.4, update old-ghcs, update bootstrap plans) #9722

Merged
merged 4 commits into from
Feb 23, 2024

Conversation

mpickering
Copy link
Collaborator

Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

.github/workflows/bootstrap.yml Outdated Show resolved Hide resolved
bootstrap/generate_bootstrap_plans Show resolved Hide resolved
@andreabedini
Copy link
Collaborator

It might be worth keeping to test that cabal-install can use an old GHC (even if it is itself built with a newer compiler). "compiled with" and "can use" are orthogonal axes.

@mpickering
Copy link
Collaborator Author

It might be worth keeping to test that cabal-install can use an old GHC (even if it is itself built with a newer compiler). "compiled with" and "can use" are orthogonal axes.

There are the "old-ghcs" jobs but those only test the ./Setup interface rather than cabal-install.

At the moment there is not CI configuration to test cabal-install with versions of GHC other than those which it has been built with. That seems worthy of another ticket but seems outside the scope of this MR.

@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Feb 23, 2024
We no longer support 8.4.4 as it is older than three years.
cabal-install can
still be used with 8.4.4, but just not built with it, and this is tested
by the old-ghcs jobs.
We were missing coverage from running tests with these ghc versions.
And add the relevant CI jobs for these plans
It fails in the old-ghcs 8.4.4 configuration, and debugging why seems to
have very little pay-off for this niche feature in a very old
configuration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants