Skip to content

Add code lens and fix code actions experiments #4224

Add code lens and fix code actions experiments

Add code lens and fix code actions experiments #4224

Triggered via pull request September 11, 2023 16:01
Status Success
Total duration 1m 18s
Artifacts

hlint.yml

on: pull_request
Hlint check run
1m 6s
Hlint check run
Fit to window
Zoom out
Zoom in

Annotations

14 warnings
Hlint check run
The following actions uses node12 which is deprecated and will be forced to run on node16: rwe/actions-hlint-setup@v1, rwe/actions-hlint-run@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Hlint check run: exe/Wrapper.hs#L1
Warning in module Main: Use module export list ▫︎ Found: "module Main where" ▫︎ Perhaps: "module Main (\n module Main\n ) where" ▫︎ Note: an explicit list is usually better
Hlint check run: ghcide/session-loader/Development/IDE/Session.hs#L621
Warning in loadSessionWithOptions in module Development.IDE.Session: Use map ▫︎ Found: "zip (map fst $ concatMap toFlagsMap all_targets) (repeat hieYaml)" ▫︎ Perhaps: "map (, hieYaml) (map fst $ concatMap toFlagsMap all_targets)" ▫︎ Note: may require `{-# LANGUAGE TupleSections #-}` adding to the top of the file
Hlint check run: ghcide/session-loader/Development/IDE/Session.hs#L825
Suggestion in newComponentCache in module Development.IDE.Session: Use let ▫︎ Found: "hscEnv' <- pure\n $ hscSetFlags\n df hsc_env {hsc_IC = (hsc_IC hsc_env) {ic_dflags = df}}" ▫︎ Perhaps: "let hscEnv'\n = hscSetFlags\n df hsc_env {hsc_IC = (hsc_IC hsc_env) {ic_dflags = df}}"
Hlint check run: ghcide/session-loader/Development/IDE/Session.hs#L977
Warning in parseMultiCradleErr in module Development.IDE.Session: Use drop1 ▫︎ Found: "drop 1" ▫︎ Perhaps: "drop1"
Hlint check run: ghcide/src/Development/IDE/Core/Compile.hs#L95
Warning in module Development.IDE.Core.Compile: Use fewer imports ▫︎ Found: "import GHC ( ForeignHValue, GetDocsFailure(..), parsedSource )\nimport GHC ( GhcException(..) )\n" ▫︎ Perhaps: "import GHC\n ( ForeignHValue,\n GetDocsFailure(..),\n parsedSource,\n GhcException(..) )\n"
Hlint check run: ghcide/src/Development/IDE/Core/Compile.hs#L301
Suggestion in captureSplicesAndDeps in module Development.IDE.Core.Compile: Move guards forward ▫︎ Found: "[moduleName mod |\n n <- uniqDSetToList (bcoFreeNames bcos),\n Just mod <- [nameModule_maybe n],\n not (isWiredInName n),\n moduleUnitId mod `elem` home_unit_ids]" ▫︎ Perhaps: "[moduleName mod |\n n <- uniqDSetToList (bcoFreeNames bcos),\n not (isWiredInName n),\n Just mod <- [nameModule_maybe n],\n moduleUnitId mod `elem` home_unit_ids]"
Hlint check run: ghcide/src/Development/IDE/Core/Compile.hs#L609
Suggestion in mkHiFileResultCompile in module Development.IDE.Core.Compile: Redundant bracket ▫︎ Found: "if isOtherUnfolding (realIdUnfolding v) then\n (setIdUnfolding v noUnfolding)\nelse\n v" ▫︎ Perhaps: "if isOtherUnfolding (realIdUnfolding v) then\n setIdUnfolding v noUnfolding\nelse\n v"
Hlint check run: ghcide/src/Development/IDE/Core/Compile.hs#L1241
Warning in parseHeader in module Development.IDE.Core.Compile: Redundant bracket ▫︎ Found: "(HsModule)" ▫︎ Perhaps: "HsModule"
Hlint check run: ghcide/src/Development/IDE/Core/FileStore.hs#L268
Suggestion in registerFileWatches in module Development.IDE.Core.FileStore: Redundant $ ▫︎ Found: "Just $ regOptions" ▫︎ Perhaps: "Just regOptions"
Hlint check run: ghcide/src/Development/IDE/Core/Rules.hs#L375
Suggestion in getLocatedImportsRule in module Development.IDE.Core.Rules: Use let ▫︎ Found: "dflags' <- return\n $ if isImplicitCradle then\n addRelativeImport file (moduleName $ ms_mod ms) dflags\n else\n dflags" ▫︎ Perhaps: "let dflags'\n = if isImplicitCradle then\n addRelativeImport file (moduleName $ ms_mod ms) dflags\n else\n dflags"
Hlint check run
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Hlint check run
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Hlint check run
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/