Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emacs/doom-emacs integration sub-section #115

Merged
merged 3 commits into from
May 18, 2020

Conversation

yuanw
Copy link
Contributor

@yuanw yuanw commented May 17, 2020

Add subsection for emacs/doom-emacs integration

Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the addition!
Some nitpicks

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated

Note to editor integrators: there is now a haskell-language-server-wrapper executable, which is installed alongside the haskell-language-server executable. When this is invoked in the project root directory, it attempts to work out the GHC version used in the project, and then launch the matching hie executable.

All of the editor integrations assume that you have already installed HLS (see above) and that stack put the hls binary in your path (usually ~/.local/bin on linux and macOS).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we ought to be build tool agnostic, since we support stack and cabal. Either mention both or be less specific, such as:

that the installation script put the haskell-language-server binary in your path ...

README.md Outdated Show resolved Hide resolved
README.md Outdated

``` emacs-lisp
(after! lsp-haskell
(setq lsp-haskell-process-path-hie "haskell-language-server-wrapper")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as above.

@jneira
Copy link
Member

jneira commented May 18, 2020

Thanks for the pr @yuanw , this make progress towards #85

Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last nitpick, otherwise LGTM

README.md Outdated Show resolved Hide resolved
@yuanw yuanw requested a review from fendor May 18, 2020 16:53
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@fendor fendor merged commit 144457f into haskell:master May 18, 2020
@yuanw yuanw deleted the doom-emacs-doc branch May 18, 2020 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants