Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete editor integrations #132

Merged
merged 14 commits into from
May 27, 2020
Merged

Complete editor integrations #132

merged 14 commits into from
May 27, 2020

Conversation

jneira
Copy link
Member

@jneira jneira commented May 26, 2020

README.md Outdated Show resolved Hide resolved
@jneira jneira requested a review from fendor May 26, 2020 07:08
README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@sir4ur0n sir4ur0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

This is a completely picky code review (fixing typos, adding monofont on key words, etc.), I hope this kind of review is tolerated here 😅 Otherwise I'm sorry 🙇

This PR looks really good, thank you! This will definitely help adoption

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
jneira and others added 9 commits May 26, 2020 21:56
Co-authored-by: Julien Debon <julien.debon@pm.me>
Co-authored-by: Julien Debon <julien.debon@pm.me>
Co-authored-by: Julien Debon <julien.debon@pm.me>
Co-authored-by: Julien Debon <julien.debon@pm.me>
Co-authored-by: Julien Debon <julien.debon@pm.me>
@jneira
Copy link
Member Author

jneira commented May 26, 2020

This is a completely picky code review (fixing typos, adding monofont on key words, etc.), I hope this kind of review is tolerated here 😅 Otherwise I'm sorry 🙇

Of course it is, many thanks to review the pr in deep and suggest improvements and corrections.

Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jneira jneira merged commit a55e371 into haskell:master May 27, 2020
@jneira jneira deleted the readme-eds branch May 27, 2020 20:55
pepeiborra pushed a commit that referenced this pull request Dec 27, 2020
That’s the publisher we use for uploading the DAML extension and it
makes little sense to have two publishers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add installation and usage instructions
6 participants