Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Use bullet as separator instead of HR" #150

Merged
merged 1 commit into from
Jun 6, 2020
Merged

Revert "Use bullet as separator instead of HR" #150

merged 1 commit into from
Jun 6, 2020

Conversation

alanz
Copy link
Collaborator

@alanz alanz commented Jun 6, 2020

In rendering documentation for hover.

Now that emacs-lsp/lsp-mode#1750 has landed

@alanz
Revert "Use bullet as separator instead of HR"
d5aeced 
In rendering documentation for hover.
@jneira
Copy link
Member

jneira commented Jun 6, 2020 •
edited
Loading

LGTM but ci fails to check out the ghcide submodule:

Submodule 'ghcide' (https://github.com/alanz/ghcide.git) registered for path 'ghcide'
Cloning into '/root/build/ghcide'...
fatal: remote error: upload-pack: not our ref 3ee692a4cdb98792c371765c9f8adb5237d0a515
Fetched in submodule path 'ghcide', but it did not contain 3ee692a4cdb98792c371765c9f8adb5237d0a515. Direct fetching of that commit failed.

Exited with code exit status 1

@alanz
Copy link
Collaborator Author

alanz commented Jun 6, 2020

Oops, pushed that branch. Is there a way to re-rerun CI?

@alanz alanz merged commit 5896026 into haskell:master Jun 6, 2020
@lukel97 lukel97 mentioned this pull request Jun 8, 2020
Closed
pepeiborra pushed a commit that referenced this pull request Dec 27, 2020
@jacg @cocreature
Signal code actions in initialize response (#150)
726af7f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneira jneira jneira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alanz @jneira