Rename the configuration section from languageServerHaskell => haskell #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches up with how other language servers name their configuration section (see https://marketplace.visualstudio.com/items?itemName=rust-lang.rust), and the new VS Code extension has already done this rename.
|
Fixes #226 |
martinrist
added a commit
to martinrist/dotfiles
that referenced
this pull request
Sep 16, 2020
`haskell-language-server` has a [change](haskell/haskell-language-server#227) in v0.2.2 to the name of the LSP configuration section. To prepare for this, we probably need two separate versions of the CoC config file, depending on whether we're using `haskell-ide-engine` or `haskell-language-server`
martinrist
added a commit
to martinrist/dotfiles
that referenced
this pull request
Sep 16, 2020
[This change](haskell/haskell-language-server#227) in v0.2.2 of `haskell-language-server` changes the title of the Haskell LSP configuration setting.
pepeiborra
pushed a commit
that referenced
this pull request
Dec 27, 2020
* Initial implementation of completion support * Add fuzzy to set of additional dependencies in 8.8 * Fix test * Work a bit more on completion * Attempt at getting completions from last good tckd module * Revert "Attempt at getting completions from last good tckd module" This reverts commit 04ca13b9d831eaaf013239cd8cbc49ea284b6de1. * "useWithStale" everywhere * Some suggestions by @cocreature * Adjust positions in the document * Start working on tests * Fix compilation problem * Fix tests * Better type tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches up with how other language servers name their configuration section (see https://marketplace.visualstudio.com/items?itemName=rust-lang.rust), and the new VS Code extension has already done this rename.
Unfortunately we forgot to also change it in haskell-language-server. This is a bit of a growing pain and will break people's configs, but thankfully the only configuration option that seems to have any effect in hls at the moment is the formatter. We need to follow this up with the equivalent change in haskell-ide-engine too.