Use wz1000/hls-3 ghcide branch #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At b7de7ae89469693b76d92ca433119d91d3a9aac0
alanz
commented
Aug 3, 2020
| let options = (defaultIdeOptions sessionLoader) | ||
| { optReportProgress = clientSupportsProgress caps | ||
| , optShakeProfiling = argsShakeProfiling | ||
| , optTesting = IdeTesting argsTesting | ||
| , optThreads = argsThreads | ||
| -- , optCheckParents = checkParents config | ||
| -- , optCheckProject = checkProject config |
There was a problem hiding this comment.
These are commented out for now, should come from the hls config, but the default values are fine (check parents on save, always check project).
|
We can simplify the hls Main driver now: Not necessarily in this PR though |
pepeiborra
approved these changes
Aug 3, 2020
|
@pepeiborra The driver simplification is already in HLS, I think it came in with the PR for the binaries |
lukel97
approved these changes
Aug 4, 2020
pepeiborra
pushed a commit
that referenced
this pull request
Dec 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At b7de7ae89469693b76d92ca433119d91d3a9aac0