Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exe extension to win executables #284

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Add exe extension to win executables #284

merged 1 commit into from
Aug 4, 2020

Conversation

jneira
Copy link
Member

@jneira jneira commented Aug 3, 2020 •
edited
Loading

@jneira jneira requested a review from lukel97 August 3, 2020 22:29
Ailrun
Ailrun reviewed Aug 3, 2020
View reviewed changes
Copy link
Member

@Ailrun Ailrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using one mv but with ${{env.EXE_EXT}} instead?

@jneira
Copy link
Member Author

jneira commented Aug 3, 2020 •
edited
Loading

@Ailrun didnt see that env var, thanks!

lukel97
lukel97 approved these changes Aug 3, 2020
View reviewed changes
Copy link
Collaborator

@lukel97 lukel97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Ailrun
Ailrun approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@Ailrun Ailrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too :)

@jneira jneira merged commit c9083ba into haskell:master Aug 4, 2020
@jneira jneira deleted the win-exe-ext branch August 4, 2020 00:44
pepeiborra pushed a commit that referenced this pull request Dec 27, 2020
@jacg @cocreature
Tests for issue #283 (#284)
b1435e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukel97 lukel97 lukel97 approved these changes

@Ailrun Ailrun Ailrun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jneira @lukel97 @Ailrun