Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to lsp changes for workspace/configuration #3773

Merged
merged 4 commits into from
Aug 25, 2023
Merged

Conversation

michaelpj
Copy link
Collaborator

DRAFT: depends on unreleased lsp code, I expect I still messed some stuff up with the tests

This has a few substantive changes and a lot of messing with tests.

  • We now tell lsp our config section, and parse just that section.
  • We move the logic for updating the shake build rules for client config from a workspace/didChangeConfiguration handler to the new lsp callback, which will ensure it gets called in all circumstances that can be relevant.

The test changes are more annoying:

  • We ignore config and logging messages by default now, so we have to stop doing that when we care about it.
  • Many tests didn't really need to change the config, but rather just to set it once at the beginning. I adjusted a lot of test functions to allow passing in the initial config for this reason.

@michaelpj
Copy link
Collaborator Author

Stack builds will fail since I haven't put the git dep in there. Shouldn't be a problem once we're using a released lsp.

@July541
Copy link
Collaborator

July541 commented Aug 24, 2023

It looks like you are just going to satisfy the lsp changes, LGTM.

This has a few substantive changes and a lot of messing with tests.

- We now tell `lsp` our config section, and parse just that section.
- We move the logic for updating the shake build rules for client config
  from a `workspace/didChangeConfiguration` handler to the new `lsp`
  callback, which will ensure it gets called in all circumstances that
  can be relevant.

The test changes are more annoying:
- We ignore config and logging messages by default now, so we have to
  stop doing that when we care about it.
- Many tests didn't really need to _change_ the config, but rather just
  to set it once at the beginning. I adjusted a lot of test functions to
  allow passing in the initial config for this reason.
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelpj michaelpj enabled auto-merge (squash) August 25, 2023 13:53
@michaelpj michaelpj merged commit e4234a3 into master Aug 25, 2023
38 checks passed
@fendor fendor mentioned this pull request Aug 25, 2023
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants