Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghcide: Only try stating a core file after we ensure it actually exists #4076

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

wz1000
Copy link
Collaborator

@wz1000 wz1000 commented Feb 15, 2024

This doesn't change any behaviour, but ensures we have a more informative error message
if we somehow request a linkable that does not exist.

…ists

This doesn't change any behaviour, but ensures we have a more informative error message
if we somehow request a linkable that does not exist.
Copy link
Collaborator

@soulomoon soulomoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look reasonable

Copy link
Collaborator

@jhrcek jhrcek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like definite improvement.

@fendor fendor enabled auto-merge (squash) February 15, 2024 09:01
@fendor fendor merged commit 3ba3f38 into master Feb 15, 2024
37 of 38 checks passed
@jhrcek jhrcek deleted the wip/linkable-fixes branch March 11, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants