Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorter file names completion #4252

Merged
merged 4 commits into from
May 27, 2024

Conversation

VenInf
Copy link
Contributor

@VenInf VenInf commented May 26, 2024

Fix for the issue #3774

To solve it I have created a wrapper of the Posix.splitFileName function.
The function by default tends to add unnecessary trailing slash

@VenInf VenInf requested a review from fendor as a code owner May 26, 2024 17:53
Copy link
Collaborator

@jhrcek jhrcek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some small documentation nitpicks!

@fendor fendor force-pushed the shorter-file-names-completion branch from a398017 to 7e20540 Compare May 27, 2024 11:58
@fendor fendor enabled auto-merge (squash) May 27, 2024 12:01
@fendor fendor merged commit a6cb43b into haskell:master May 27, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants