Avoid expectFail in the test suite #4402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgillespie
force-pushed
the
master
branch
3 times, most recently
from
4ad8f08
to
edfc677
Compare
sgillespie
changed the title
fendor
approved these changes
Sep 28, 2024
sgillespie
requested review from
santiweight,
VeryMilkyJoe and
wz1000
as code owners
Create a type-level failure expectations, which allows us to add the expected failure behavior and the future ideal behavior
Yes it's ready, I was just waiting for CI to complete |
michaelpj
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace some
expectFailreferences with explicit checks. Note that there are some remaining references that should probably be changed.Addresses #4130
I've added TODO comments to most of the tests to explain what's wrong (that is, if I could correctly guess it). I wonder if it would be better to have issue numbers instead.