Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to configure the number of shake threads #230

Closed
wants to merge 1 commit into from

Conversation

lukel97
Copy link
Collaborator

@lukel97 lukel97 commented May 23, 2020

Only on ghcide and haskell-language-server

haskell/ghcide@3960533

@jneira
Copy link
Member

jneira commented May 23, 2020

Uhmm, this could be useful, but it seems to me that it will be a thing mainly oriented to ghcide/hls developers.
Not sure i it worths add a specific option visible to everybody, as you can make a wrapper for example and pass the argument there.

@lukel97
Copy link
Collaborator Author

lukel97 commented May 23, 2020

True. We could alternatively just always pass -j 0, but I guess this depends on whether or not we want multithreading to be the default. Does anyone know if it’s considered experimental or stable?

@jneira
Copy link
Member

jneira commented May 23, 2020

Well, maybe a slightly more generic name could make it more user oriented: languageServerHaskell.numThreads or a boolean multithreading.
Is not -j 0 already the default value?

@lukel97
Copy link
Collaborator Author

lukel97 commented May 23, 2020

You might be right. We don't pass -j 0 by default but I'll need to check if leaving out -j is actually multithreaded – I had just assumed it was the same behaviour as make

@lukel97
Copy link
Collaborator Author

lukel97 commented May 24, 2020

After a bit of poking, it does look like ghcide sets the number of shake threads to 0 by default, which should mean it is by default multithreaded. But on haskell-language-server, it defaults to 1, so single threaded. I think this is probably more of an oversight in hls, I will address that there

lukel97 added a commit to haskell/haskell-language-server that referenced this pull request May 24, 2020
This will mean that it is multithreaded by default, but will match the
behaviour in ghcide.
haskell/vscode-haskell#230
lukel97 added a commit to haskell/haskell-language-server that referenced this pull request May 24, 2020
This will mean that it is multithreaded by default, but will match the
behaviour in ghcide.
haskell/vscode-haskell#230
@lukel97 lukel97 closed this Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants