Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gh actions and go versions, update deprecated ioutil #98

Merged
merged 4 commits into from
Jul 28, 2023

Conversation

davidbloss
Copy link

Version Updates

  • Update Github Actions since these actions are built on deprecated node12 tagged actions.
  • Update Go module version to 1.20. The EOL of current Go version 1.16 was on 15 Mar 2022.
  • Update ioutil.ReadAll to io.ReadAll

All go.mod updates were a result of setting go 1.20 in go.mod then running go get -u ./... followed by go mod tidy.

@hgiasac
Copy link

hgiasac commented Jul 26, 2023

Hi @davidbloss
Thanks for contributing. Anyway, the coverage tool doesn't support the latest Go version I guess. Can you help remove that step to pass the test? Thanks

@davidbloss
Copy link
Author

Hi @davidbloss Thanks for contributing. Anyway, the coverage tool doesn't support the latest Go version I guess. Can you help remove that step to pass the test? Thanks

Hi @hgiasac 👋
I think it should work by replacing "go get" with "go install" see deprecation notice

@hgiasac
Copy link

hgiasac commented Jul 28, 2023

Thanks for your hard work. There is another issue, but I'll take it up to save your time

@hgiasac hgiasac merged commit 8a758d3 into hasura:master Jul 28, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants