Add header parsing for headers in individual routes #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingkarthik
approved these changes
May 29, 2024
m-Bilal
added a commit
that referenced
this pull request
Jun 2, 2024
…al addition of headers (#28) Follow up to #27 ## Issue https://hasurahq.atlassian.net/browse/EDC-30 ## Description This PR adds an optional parameter called `headers` in every function in `functions.ts`. This optional `headers` parameter will accept headers that the DDN Engine will forward to this data connector. Because headers will be forwarded by the DDN Engine, manual addition of headers has been removed. Tests have been updated to reflect that. ## Commits * parsing logic that considers both global and local headers * documentation * add optional headers argument in functions template * tests updated * removed manual addition of headers * format * PR link in changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://hasurahq.atlassian.net/browse/EDC-30
Description
This PR introduces header parsing for every individual API route in the OpenAPI Document. The previous support for headers applied headers to all routes, and the headers had to be specified manually. While that's still supported, this new header parser can pick up headers that are defined in the path parameters and parse them
The main parser is the file header-parser.ts and the tests are in header-parser.test.ts. All other changes are accommodation changes for the header parser.