Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable help for disabled plugins #1087

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Conversation

mmuzikar
Copy link
Contributor

Dev build connected to quarkus looks like this:
image
with "disabledRoutes": ["/disabled", "/camel", "/quartz"]:
image

Copy link

Test Results

  8 files  ±  0    8 suites  ±0   42m 13s ⏱️ + 15m 48s
 66 tests ±  0   64 ✅ ±  0   2 💤 ± 0  0 ❌ ±0 
536 runs  +198  508 ✅ +187  28 💤 +11  0 ❌ ±0 

Results for commit ac8ad3e. ± Comparison against base commit bdc7f40.

@hawtio-ci
Copy link

hawtio-ci bot commented Aug 29, 2024

Test results

Run attempt: 2215
Detailed summary

NAME TESTS PASSED ✅ SKIPPED 💤 FAILED ❌ ERRORS 🚫 TIME 🕖
results-quarkus-node(18)-java(17)-firefox 67 64 3 0 0 321.963
results-quarkus-node(18)-java(21)-firefox 67 64 3 0 0 324.678
results-quarkus-node(20)-java(17)-firefox 67 64 3 0 0 319.975
results-quarkus-node(20)-java(21)-firefox 67 64 3 0 0 311.79
results-springboot-node(18)-java(17)-firefox 67 63 4 0 0 309.681
results-springboot-node(18)-java(21)-firefox 67 63 4 0 0 319.02
results-springboot-node(20)-java(17)-firefox 67 63 4 0 0 313.786
results-springboot-node(20)-java(21)-firefox 67 63 4 0 0 312.222

Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@tadayosi tadayosi merged commit 8c6f3c8 into hawtio:main Aug 30, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hawtconfig disableRoutes should also hide preferences and help for a disabled plugin
2 participants