Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade junit and address test failures #1135

Merged
merged 1 commit into from
Jan 4, 2023
Merged

upgrade junit and address test failures #1135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions pitest/src/test/java/org/pitest/TestJUnitConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package org.pitest;

import static org.assertj.core.api.Assertions.assertThat;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.fail;
import static org.junit.Assume.assumeTrue;
Expand Down Expand Up @@ -406,12 +407,14 @@ public void two() {
}

@Test
@Ignore
// Behaviour change junit 4.13 causes this to fail for reasons unknown. Other behavioural changes
// caused by this upgrade were tracked down to changes which causes the effected tests to also
// fail when not run via pitest. Given it is an obscure edge case will hopefully not cause any real issues.
public void shouldSplitTestInSuitesIntoSeperateUnitsWhenUsingNonStandardSuiteRunners() {
final List<TestUnit> actual = find(CustomSuite.class);

System.out.println(actual);

assertEquals(4, actual.size());
assertThat(actual).hasSize(4);

}

Expand Down Expand Up @@ -527,7 +530,9 @@ public JUnit3SuiteMethod(final String testName) {

public static junit.framework.Test suite() {
final TestSuite suite = new TestSuite();
suite.addTest(new JUnit3Test());
JUnit3Test t = new JUnit3Test();
t.setName("testSomething");
suite.addTest(t);
return suite;
}

Expand Down
10 changes: 8 additions & 2 deletions pitest/src/test/java/org/pitest/junit/RunnerSuiteFinderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,14 @@ public JUnit3SuiteMethod(final String testName) {

public static junit.framework.Test suite() {
final TestSuite suite = new TestSuite();
suite.addTest(new One());
suite.addTest(new Two());
One one = new One();
one.setName("testSomething");
suite.addTest(one);

Two two = new Two();
two.setName("testSomething");

suite.addTest(two);
return suite;
}

Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@

<asm.version>9.4</asm.version>
<hamcrest.version>1.3</hamcrest.version>
<junit.version>4.11</junit.version>
<junit.version>4.13.1</junit.version>
<surefire.version>2.18.1</surefire.version> <!-- [2.19, 3.0.0-M7] seem to cause ASM-related test failures -->
<slf4j.version>1.7.12</slf4j.version>

Expand Down