Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pull changes from Forupstream to update hebcal_test.go and zmanim_test.go #11

Closed
wants to merge 2 commits into from
Closed

pull changes from Forupstream to update hebcal_test.go and zmanim_test.go #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
372ec3a
Update zmanim.go
MaxBGreenberg Jan 30, 2024
4d62b8b
Update zmanim_test.go
MaxBGreenberg Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions zmanim/zmanim.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,13 @@ func (z *Zmanim) Tzeit(angle float64) time.Time {
return z.timeAtAngle(angle, false)
}

// Rabbeinu Tam holds that bein hashmashos is a specific time between sunset and tzeis hakochavim
// One opinion on how to calculate this time is that it is 13.5 minutes before tzies 7.083
func (z *Zmanim) BeinHashmashos() time.Time {
tzeis:=z.Tzeit(Tzeit3MediumStars)
return tzeis.Add(-time.Duration(13.5 * float64(time.Minute)))
}

func (z *Zmanim) riseSetOffset(t time.Time, offset int, roundTime bool) time.Time {
if t == nilTime {
return t
Expand Down
1 change: 1 addition & 0 deletions zmanim/zmanim_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@
zman.PlagHaMincha(),
zman.Sunset(),
zman.Dusk(),
zman.BeinHashmashos()

Check failure on line 110 in zmanim/zmanim_test.go

View workflow job for this annotation

GitHub Actions / build 

missing ',' before newline in composite literal
zman.Tzeit(8.5),
}
actual := make([]string, 18)
Expand Down
Loading