Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update candles.go. #8

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Update candles.go. #8

merged 2 commits into from
Jan 30, 2024

Conversation

MaxBGreenberg
Copy link
Contributor

Move MGA zmanin before GRA zmanim
Explicitly label GRA zmanim

@mjradwin
Copy link
Member

Hi @MaxBGreenberg this change looks good, but it looks like it causes the TestDailyZemanim unit test to fail. Can you fix hebcal_test.go and include it in this PR?

Copy link

sonarcloud bot commented Jan 30, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
50.0% Duplication on New Code

See analysis details on SonarCloud

@mjradwin mjradwin merged commit 7b39dcc into hebcal:main Jan 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants