Allow multi key remappings in config file (#454)

* Use tree like structure to store keymaps * Allow multi key keymaps in config file * Allow multi key keymaps in insert mode * Make keymap state self contained * Add keymap! macro for ergonomic declaration * Add descriptions for editor commands * Allow keymap! to take multiple keys * Restore infobox display * Fix keymap merging and add infobox titles * Fix and add tests for keymaps * Clean up comments and apply suggestions * Allow trailing commas in keymap! * Remove mode suffixes from keymaps * Preserve order of keys when showing infobox * Make command descriptions smaller * Strip infobox title prefix from items * Strip infobox title prefix from items
helix-editor · Jul 26, 2021 · 88d6f65 · 88d6f65
1 parent a630fb5
commit 88d6f65
Show file tree

Hide file tree

Showing 8 changed files with 730 additions and 608 deletions.
diff --git a/helix-term/src/commands.rs b/helix-term/src/commands.rs
diff --git a/helix-term/src/config.rs b/helix-term/src/config.rs
@@ -2,9 +2,6 @@ use serde::Deserialize;
 
 use crate::keymap::Keymaps;
 
-#[cfg(test)]
-use crate::commands::Command;
-
 #[derive(Debug, Default, Clone, PartialEq, Deserialize)]
 pub struct Config {
     pub theme: Option<String>,
@@ -22,12 +19,10 @@ pub struct LspConfig {
 
 #[test]
 fn parsing_keymaps_config_file() {
+    use crate::keymap;
+    use crate::keymap::Keymap;
     use helix_core::hashmap;
-    use helix_view::{
-        document::Mode,
-        input::KeyEvent,
-        keyboard::{KeyCode, KeyModifiers},
-    };
+    use helix_view::document::Mode;
 
     let sample_keymaps = r#"
             [keys.insert]
@@ -42,22 +37,13 @@ fn parsing_keymaps_config_file() {
         toml::from_str::<Config>(sample_keymaps).unwrap(),
         Config {
             keys: Keymaps(hashmap! {
-                Mode::Insert => hashmap! {
-                    KeyEvent {
-                        code: KeyCode::Char('y'),
-                        modifiers: KeyModifiers::NONE,
-                    } => Command::move_line_down,
-                    KeyEvent {
-                        code: KeyCode::Char('a'),
-                        modifiers: KeyModifiers::SHIFT | KeyModifiers::CONTROL,
-                    } => Command::delete_selection,
-                },
-                Mode::Normal => hashmap! {
-                    KeyEvent {
-                        code: KeyCode::F(12),
-                        modifiers: KeyModifiers::ALT,
-                    } => Command::move_next_word_end,
-                },
+                Mode::Insert => Keymap::new(keymap!({ "Insert mode"
+                    "y" => move_line_down,
+                    "S-C-a" => delete_selection,
+                })),
+                Mode::Normal => Keymap::new(keymap!({ "Normal mode"
+                    "A-F12" => move_next_word_end,
+                })),
             }),
             ..Default::default()
         }