Auto-format selects entire document #2404

BonfireAtNight · 2022-05-05T08:15:37Z

BonfireAtNight
May 5, 2022

I'm using Helix to write Python (with pylsp). When running the auto-format (via the : format command) afterwards the entire document is selected and the cursor is in line 1. Is this intended behavior? Personally, I would much prefer if my cursor would be exactly where it was before I executed the command. For instance, it's like this when I run clangd in vim.

Answered by kirawi

Sep 30, 2022

This should be fixed by #4041

View full answer

kirawi · 2022-05-05T12:30:35Z

kirawi
May 5, 2022
Collaborator

I encountered this with rust-analyzer before. The line endings were different from what the LSP expected, and so formatting it would basically delete the entire document and send the new one with the correct line endings. Maybe you're seeing something similar? Could you report what your logs say?

2 replies

BonfireAtNight May 5, 2022
Author

This results in a log file with 1993 lines. As far as I can see, many are similar to:

2022-05-04T20:06:33.383 helix_term::application [WARN] lsp position out of bounds - Diagnostic { range: Range { start: Position { line: 62, character: 0 }, end: Position { line: 62, character: 100 } }, severity: Some(Warning), code: Some(String("E901")), code_description: None, source: Some("pycodestyle"), message: "E901 TokenError: EOF in multi-line statement", related_information: None, tags: None, data: None }

I think this could be similar to your "line endings were different from what the LSP expected"?

kirawi May 6, 2022
Collaborator

It's not diagnostics, rather it would be similar to what @David-Else posted, particularly lines like so:

2022-05-05T17:44:19.636 helix_lsp::transport [INFO] <- {"jsonrpc":"2.0","id":1,"result":[{"range":{"start":{"line":0,"character":0},"end":{"line":11,"character":7}},"newText":"<!DOCTYPE html>\n<html>\n\n<body>\n\n  <h1>My First Heading</h1>\n\n  <p> My first paragraph.</p>\n\n</body>\n\n</html>"}]}

Here it looks like an entirely new document was indeed sent. I would suggest diffing the pre-formatted (after manually formatting it) and post-formatted doc to see what might be causing it?

David-Else · 2022-05-05T16:49:51Z

David-Else
May 5, 2022

It does the same with the HTML LSP!

2022-05-05T17:44:16.666 helix_lsp::client [INFO] Using custom LSP config: {"provideFormatter":true}
2022-05-05T17:44:16.666 helix_lsp::transport [INFO] -> {"jsonrpc":"2.0","method":"initialize","params":{"capabilities":{"textDocument":{"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":["","quickfix","refactor","refactor.extract","refactor.inline","refactor.rewrite","source","source.organizeImports"]}}},"completion":{"completionItem":{"resolveSupport":{"properties":["documentation","detail","additionalTextEdits"]},"snippetSupport":false},"completionItemKind":{}},"hover":{"contentFormat":["markdown"]},"publishDiagnostics":{},"rename":{"dynamicRegistration":false,"honorsChangeAnnotations":false,"prepareSupport":false}},"window":{"workDoneProgress":true},"workspace":{"configuration":true,"didChangeConfiguration":{"dynamicRegistration":false},"workspaceFolders":true}},"initializationOptions":{"provideFormatter":true},"processId":413101,"rootUri":null,"workspaceFolders":[]},"id":0}
2022-05-05T17:44:17.161 helix_lsp::transport [INFO] <- {"jsonrpc":"2.0","id":0,"result":{"capabilities":{"textDocumentSync":2,"hoverProvider":true,"documentHighlightProvider":true,"documentRangeFormattingProvider":true,"documentFormattingProvider":true,"documentLinkProvider":{"resolveProvider":false},"documentSymbolProvider":true,"definitionProvider":true,"signatureHelpProvider":{"triggerCharacters":["("]},"referencesProvider":true,"colorProvider":{},"foldingRangeProvider":true,"selectionRangeProvider":true,"renameProvider":true,"linkedEditingRangeProvider":true}}}
2022-05-05T17:44:17.161 helix_lsp::transport [INFO] <- {"capabilities":{"colorProvider":{},"definitionProvider":true,"documentFormattingProvider":true,"documentHighlightProvider":true,"documentLinkProvider":{"resolveProvider":false},"documentRangeFormattingProvider":true,"documentSymbolProvider":true,"foldingRangeProvider":true,"hoverProvider":true,"linkedEditingRangeProvider":true,"referencesProvider":true,"renameProvider":true,"selectionRangeProvider":true,"signatureHelpProvider":{"triggerCharacters":["("]},"textDocumentSync":2}}
2022-05-05T17:44:17.161 helix_lsp::transport [INFO] -> {"jsonrpc":"2.0","method":"initialized","params":{}}
2022-05-05T17:44:17.161 helix_lsp::transport [INFO] -> {"jsonrpc":"2.0","method":"workspace/didChangeConfiguration","params":{"settings":{"provideFormatter":true}}}
2022-05-05T17:44:17.161 helix_lsp::transport [INFO] -> {"jsonrpc":"2.0","method":"textDocument/didOpen","params":{"textDocument":{"languageId":"basic","text":"<!DOCTYPE html>\n<html>\n\n<body>\n\n  <h1>My First Heading</h1>\n\n  <p> My first paragraph.</p>\n\n</body>\n\n</html>","uri":"file:///home/david/Downloads/x.html","version":0}}}
2022-05-05T17:44:17.163 helix_lsp::transport [INFO] <- {"jsonrpc":"2.0","id":0,"method":"client/registerCapability","params":{"registrations":[{"id":"b872d25b-193f-4006-886e-a86c1b06b48e","method":"workspace/didChangeWorkspaceFolders","registerOptions":{}}]}}
2022-05-05T17:44:17.163 helix_lsp [WARN] unhandled lsp request: client/registerCapability
2022-05-05T17:44:17.163 helix_term::application [ERROR] Method not found client/registerCapability
2022-05-05T17:44:18.941 helix_lsp::transport [INFO] -> {"jsonrpc":"2.0","method":"textDocument/didChange","params":{"contentChanges":[{"range":{"end":{"character":0,"line":3},"start":{"character":0,"line":3}},"text":" "}],"textDocument":{"uri":"file:///home/david/Downloads/x.html","version":1}}}
2022-05-05T17:44:19.134 helix_lsp::transport [INFO] -> {"jsonrpc":"2.0","method":"textDocument/didChange","params":{"contentChanges":[{"range":{"end":{"character":1,"line":3},"start":{"character":1,"line":3}},"text":" "}],"textDocument":{"uri":"file:///home/david/Downloads/x.html","version":2}}}
2022-05-05T17:44:19.622 helix_lsp::transport [INFO] -> {"jsonrpc":"2.0","method":"textDocument/formatting","params":{"options":{"insertSpaces":true,"tabSize":2},"textDocument":{"uri":"file:///home/david/Downloads/x.html"}},"id":1}
2022-05-05T17:44:19.623 helix_lsp::transport [INFO] <- {"jsonrpc":"2.0","id":1,"method":"workspace/configuration","params":{"items":[{"scopeUri":"file:///home/david/Downloads/x.html","section":"css"},{"scopeUri":"file:///home/david/Downloads/x.html","section":"html"},{"scopeUri":"file:///home/david/Downloads/x.html","section":"javascript"}]}}
2022-05-05T17:44:19.623 helix_lsp::transport [INFO] -> {"jsonrpc":"2.0","result":[null,null,null],"id":1}
2022-05-05T17:44:19.636 helix_lsp::transport [INFO] <- {"jsonrpc":"2.0","id":1,"result":[{"range":{"start":{"line":0,"character":0},"end":{"line":11,"character":7}},"newText":"<!DOCTYPE html>\n<html>\n\n<body>\n\n  <h1>My First Heading</h1>\n\n  <p> My first paragraph.</p>\n\n</body>\n\n</html>"}]}
2022-05-05T17:44:19.636 helix_lsp::transport [INFO] <- [{"newText":"<!DOCTYPE html>\n<html>\n\n<body>\n\n  <h1>My First Heading</h1>\n\n  <p> My first paragraph.</p>\n\n</body>\n\n</html>","range":{"end":{"character":7,"line":11},"start":{"character":0,"line":0}}}]
2022-05-05T17:44:19.636 helix_lsp::transport [INFO] -> {"jsonrpc":"2.0","method":"textDocument/didChange","params":{"contentChanges":[{"range":{"end":{"character":7,"line":11},"start":{"character":0,"line":0}},"text":"<!DOCTYPE html>\n<html>\n\n<body>\n\n  <h1>My First Heading</h1>\n\n  <p> My first paragraph.</p>\n\n</body>\n\n</html>"}],"textDocument":{"uri":"file:///home/david/Downloads/x.html","version":3}}}
2022-05-05T17:44:22.430 helix_lsp::transport [INFO] -> {"jsonrpc":"2.0","method":"shutdown","params":null,"id":2}
2022-05-05T17:44:22.431 helix_lsp::transport [INFO] <- {"jsonrpc":"2.0","id":2,"result":null}
2022-05-05T17:44:22.431 helix_lsp::transport [INFO] <- null
2022-05-05T17:44:22.431 helix_lsp::transport [INFO] -> {"jsonrpc":"2.0","method":"exit","params":null}

0 replies

kirawi · 2022-09-30T02:30:42Z

kirawi
Sep 30, 2022
Collaborator

This should be fixed by #4041

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Auto-format selects entire document #2404

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Replies: 3 comments 2 replies

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

Select a reply

Auto-format selects entire document #2404

BonfireAtNight May 5, 2022

Replies: 3 comments · 2 replies

kirawi May 5, 2022 Collaborator

BonfireAtNight May 5, 2022 Author

kirawi May 6, 2022 Collaborator

David-Else May 5, 2022

kirawi Sep 30, 2022 Collaborator

BonfireAtNight
May 5, 2022

Replies: 3 comments 2 replies

kirawi
May 5, 2022
Collaborator

BonfireAtNight May 5, 2022
Author

kirawi May 6, 2022
Collaborator

David-Else
May 5, 2022

kirawi
Sep 30, 2022
Collaborator