Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freezes when editing Markdown with embedded JavaScript #10032

Closed
LukasKnuth opened this issue Mar 28, 2024 · 3 comments
Closed

Freezes when editing Markdown with embedded JavaScript #10032

LukasKnuth opened this issue Mar 28, 2024 · 3 comments
Labels
C-bug Category: This is a bug

Comments

@LukasKnuth
Copy link
Contributor

Summary

While editing a fenced JavaScript code-snippet in a Markdown file, the Editor freezes up. It does not react to anything and I have to kill -9 it in order to close the process.

Reproduction Steps

```javascript
 {
arg
}

```

NOTE The empty line at the end of the code-block is important!

I tried this:

  1. hx minimal_error.md
  2. Navigate the cursor somehow onto the closing curly-bracket
  3. The editor freezes while hovering the closing curly-bracket

NOTE: I can navigate around that closing curly-bracket as much as I like. It does not matter if I navigate onto it from the top using jjj or from the bottom using gekk. As long as I don't hover the bracket, the editor behaves as expected.

I expected this to happen:

The editor does not freeze and

Instead, this happened:

The editor freezes and must be killed using kill -9

Helix log

~/.cache/helix/helix.log I have killed the editor about 30 times now trying to get a minimum reproducible snippet. All I see in the log from that time are the errors listed below, there is no additional information.
2024-03-28T11:50:37.771 helix_lsp::transport [ERROR] marksman err <- "[11:50:37 INF] <LSP Entry> Starting Marksman LSP ser
ver: {}\n"
2024-03-28T11:52:03.098 helix_lsp::transport [ERROR] marksman err <- "[11:52:03 INF] <LSP Entry> Starting Marksman LSP ser
ver: {}\n"
2024-03-28T11:52:57.661 helix_lsp::transport [ERROR] marksman err <- "[11:52:57 INF] <LSP Entry> Starting Marksman LSP ser
ver: {}\n"
2024-03-28T11:54:21.963 helix_lsp::transport [ERROR] marksman err <- "[11:54:21 INF] <LSP Entry> Starting Marksman LSP ser
ver: {}\n"

Platform

macOS

Terminal Emulator

iTerm2

Installation Method

brew

Helix Version

helix 23.10 (f6021dd)

@LukasKnuth LukasKnuth added the C-bug Category: This is a bug label Mar 28, 2024
@pascalkuthe
Copy link
Member

know issue withi the last release caused by a bug in an old treesitter version, this has been fixed on master for a long time

@pascalkuthe pascalkuthe closed this as not planned Won't fix, can't repro, duplicate, stale Mar 28, 2024
@LukasKnuth
Copy link
Contributor Author

So the fix is to build the editor from source?

Any plans for a new release with the fixes?

@the-mikedavis
Copy link
Member

Or await the next release. We're planning to cut the next release in the next few days #9946

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug
Projects
None yet
Development

No branches or pull requests

3 participants