Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add changelog notes for 24.03 #9946

Merged
merged 7 commits into from
Mar 30, 2024
Merged

Add changelog notes for 24.03 #9946

merged 7 commits into from
Mar 30, 2024

Conversation

the-mikedavis
Copy link
Member

No description provided.

@the-mikedavis the-mikedavis added A-documentation Area: Documentation improvements S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 20, 2024
@the-mikedavis the-mikedavis added this to the 24.03 milestone Mar 20, 2024
cartwatson
cartwatson reviewed Mar 22, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
pascalkuthe
pascalkuthe reviewed Mar 26, 2024
View reviewed changes
Copy link
Member

@pascalkuthe pascalkuthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together!

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@the-mikedavis the-mikedavis mentioned this pull request Mar 28, 2024
Closed
@chenrui333 chenrui333 mentioned this pull request Mar 28, 2024
Merged
1 task
@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 30, 2024
@the-mikedavis the-mikedavis marked this pull request as ready for review March 30, 2024 12:54
@archseer archseer merged commit 2cadec0 into master Mar 30, 2024
6 checks passed
@archseer archseer deleted the changelog branch March 30, 2024 13:28
chenrui333
chenrui333 reviewed Mar 30, 2024
View reviewed changes
Cargo.toml
@@ -41,7 +41,7 @@ tree-sitter = { version = "0.22" }
nucleo = "0.2.0"

[workspace.package]
version = "23.10.0"
version = "24.3.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be 24.03.0 rather than 24.3.0?

relates to Homebrew/homebrew-core#167564

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally yes but Cargo doesn't consider it a valid version

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any cargo issue for this?

Somehow this version scheme worked before? see Homebrew/homebrew-core#131283

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so - it's a conflict of us using the version as CalVer but cargo explicitly only supporting SemVer so I doubt cargo would be interested in changing it.

The way we handle the version changed in the 23.10 release with #8925 but this effect wasn't visible yet because of the October release (10). Previously we had all crate versions at v0.6.0 (the last SemVer release version) and used an ad-hoc VERSION file and constant for the CalVer version.

@the-mikedavis the-mikedavis mentioned this pull request Mar 30, 2024
Closed
Desdaemon pushed a commit to Desdaemon/helix that referenced this pull request Apr 3, 2024
@the-mikedavis @Desdaemon
Add changelog notes for 24.03 (helix-editor#9946)
6ad04db 
* changelog: Checkpoint 2024-03-20

commit: b8e79c0

* Bump the version to 24.3.0

* changelog: Checkpoint 2024-03-25

commit: 614a744

* Address review comments

* changelog: Checkpoint 2024-03-30

commit: 64c1de1

* Adjust release day to 2024-03-30

* Linkify
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
@the-mikedavis @postsolar
Add changelog notes for 24.03 (helix-editor#9946)
470faa2 
* changelog: Checkpoint 2024-03-20

commit: b8e79c0

* Bump the version to 24.3.0

* changelog: Checkpoint 2024-03-25

commit: 614a744

* Address review comments

* changelog: Checkpoint 2024-03-30

commit: 64c1de1

* Adjust release day to 2024-03-30

* Linkify
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
@the-mikedavis @postsolar
Add changelog notes for 24.03 (helix-editor#9946)
339a90a 
* changelog: Checkpoint 2024-03-20

commit: b8e79c0

* Bump the version to 24.3.0

* changelog: Checkpoint 2024-03-25

commit: 614a744

* Address review comments

* changelog: Checkpoint 2024-03-30

commit: 64c1de1

* Adjust release day to 2024-03-30

* Linkify
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
@the-mikedavis @postsolar
Add changelog notes for 24.03 (helix-editor#9946)
e5b65c3 
* changelog: Checkpoint 2024-03-20

commit: b8e79c0

* Bump the version to 24.3.0

* changelog: Checkpoint 2024-03-25

commit: 614a744

* Address review comments

* changelog: Checkpoint 2024-03-30

commit: 64c1de1

* Adjust release day to 2024-03-30

* Linkify
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 20, 2024
@the-mikedavis @postsolar
Add changelog notes for 24.03 (helix-editor#9946)
452439b 
* changelog: Checkpoint 2024-03-20

commit: b8e79c0

* Bump the version to 24.3.0

* changelog: Checkpoint 2024-03-25

commit: 614a744

* Address review comments

* changelog: Checkpoint 2024-03-30

commit: 64c1de1

* Adjust release day to 2024-03-30

* Linkify
@atyagi9006

This comment has been minimized.

Sign in to view
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
@the-mikedavis @mtoohey31
Add changelog notes for 24.03 (helix-editor#9946)
98a4e52 
* changelog: Checkpoint 2024-03-20

commit: b8e79c0

* Bump the version to 24.3.0

* changelog: Checkpoint 2024-03-25

commit: 614a744

* Address review comments

* changelog: Checkpoint 2024-03-30

commit: 64c1de1

* Adjust release day to 2024-03-30

* Linkify
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
@the-mikedavis @Vulpesx
Add changelog notes for 24.03 (helix-editor#9946)
9827e61 
* changelog: Checkpoint 2024-03-20

commit: b8e79c0

* Bump the version to 24.3.0

* changelog: Checkpoint 2024-03-25

commit: 614a744

* Address review comments

* changelog: Checkpoint 2024-03-30

commit: 64c1de1

* Adjust release day to 2024-03-30

* Linkify
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
@the-mikedavis
Add changelog notes for 24.03 (helix-editor#9946)
ea45263 
* changelog: Checkpoint 2024-03-20

commit: b8e79c0

* Bump the version to 24.3.0

* changelog: Checkpoint 2024-03-25

commit: 614a744

* Address review comments

* changelog: Checkpoint 2024-03-30

commit: 64c1de1

* Adjust release day to 2024-03-30

* Linkify
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 chenrui333 left review comments

@cartwatson cartwatson cartwatson left review comments

@pascalkuthe pascalkuthe pascalkuthe left review comments

@archseer archseer archseer approved these changes

Assignees
No one assigned
Labels
A-documentation Area: Documentation improvements S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
24.03
Development

Successfully merging this pull request may close these issues.
6 participants
@the-mikedavis @atyagi9006 @archseer @chenrui333 @cartwatson @pascalkuthe