Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helix hangs when attemtpting to open a Zig file. #1269

Closed
paoda opened this issue Dec 14, 2021 · 6 comments · Fixed by #1429
Closed

Helix hangs when attemtpting to open a Zig file. #1269

paoda opened this issue Dec 14, 2021 · 6 comments · Fixed by #1429
Labels
C-bug Category: This is a bug upstream

Comments

@paoda
Copy link

paoda commented Dec 14, 2021

Reproduction steps

asciicast

Environment

  • Platform: Linux 5.15.7-arch1-1 x86_64 GNU/Linux
  • Helix version: helix v0.5.0-235-g94535fa0
  • Zig version: 0.9.0-dev.1952+5d1aab72d
  • ZLS version: 0.2.0

Note

I tried having ~./config/helix/languages.toml contain the following:

[[language]]
name = "zig"
language-server = {}

Surprisingly, Helix still hung when trying to open src/main.zig

What Helix was trying to open can be found here

~/.cache/helix/helix.log is not written to at any point.

@paoda paoda added the C-bug Category: This is a bug label Dec 14, 2021
@archseer
Copy link
Member

Looks like maxxnino/tree-sitter-zig#8

@paoda
Copy link
Author

paoda commented Dec 14, 2021

I tried bumping tree-sitter-zig to maxxnino/tree-sitter-zig@cf93353 which you can see here: https://github.com/paoda/helix/commit/fddcd85d287c71516bb28e2b4f4d5bbf7ba17c45

However, it seems like the upstream issue hasn't been resolved quite yet.
asciicast

@archseer
Copy link
Member

Oh, I'm suggesting you upgrade tree-sitter itself (not the grammar) so that it includes this commit: tree-sitter/tree-sitter@25f64e1

@paoda
Copy link
Author

paoda commented Dec 14, 2021

Whoops, my bad. Bumping tree-sitter in helix-core and helix-syntax worked. Thanks for the clarification.

@archseer
Copy link
Member

So the fix worked? :)

@paoda
Copy link
Author

paoda commented Dec 14, 2021

Yeah, I don't know why I left that out 😅 . I assume Helix will resolve this issue whenever tree-sitter receives its next update then.

@archseer archseer linked a pull request Jan 4, 2022 that will close this issue
capezotte added a commit to capezotte/yago that referenced this issue Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug upstream
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants