Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shrink_selection does not properly restore cursor with multiple selections. #6092

Closed
gibbz00 opened this issue Feb 23, 2023 · 0 comments · Fixed by #6093 · May be fixed by #6198
Closed

shrink_selection does not properly restore cursor with multiple selections. #6092

gibbz00 opened this issue Feb 23, 2023 · 0 comments · Fixed by #6093 · May be fixed by #6198
Labels
C-bug Category: This is a bug

Comments

@gibbz00
Copy link
Contributor

gibbz00 commented Feb 23, 2023 •
edited
Loading

Summary

Asciinema says most of it.

Reproduction Steps

asciicast

Platform

Linux

Terminal Emulator

kitty
@gibbz00 gibbz00 added the C-bug Category: This is a bug label Feb 23, 2023
gibbz00 added a commit to gibbz00/helix that referenced this issue Feb 23, 2023
@gibbz00
Fix helix-editor#6092
d93f9e7 
Cause were some incorrect assumptions that missed an edge case in the
`Selection.contains()` calculation. Tests were added accordingly.
@gibbz00 gibbz00 mentioned this issue Feb 23, 2023
Merged
@dead10ck dead10ck mentioned this issue Mar 6, 2023
Open
archseer pushed a commit that referenced this issue Mar 9, 2023
@gibbz00
Fix shrink_selection with multiple cursors. (#6093)
2cf4ce2 
* Fix #6092

Cause were some incorrect assumptions that missed an edge case in the
`Selection.contains()` calculation. Tests were added accordingly.

* Fix Selection.contains() edge-case handling.

Removing the len check short-circuit was the only thing needed as
pointed out by @dead10ck.
sagnibak pushed a commit to sagnibak/helix that referenced this issue Mar 21, 2023
@gibbz00
Fix shrink_selection with multiple cursors. (helix-editor#6093)
d905ad1 
* Fix helix-editor#6092

Cause were some incorrect assumptions that missed an edge case in the
`Selection.contains()` calculation. Tests were added accordingly.

* Fix Selection.contains() edge-case handling.

Removing the len check short-circuit was the only thing needed as
pointed out by @dead10ck.
wes-adams pushed a commit to wes-adams/helix that referenced this issue Jul 4, 2023
@gibbz00 @wes-adams
Fix shrink_selection with multiple cursors. (helix-editor#6093)
8b90f21 
* Fix helix-editor#6092

Cause were some incorrect assumptions that missed an edge case in the
`Selection.contains()` calculation. Tests were added accordingly.

* Fix Selection.contains() edge-case handling.

Removing the len check short-circuit was the only thing needed as
pointed out by @dead10ck.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug
Projects
None yet
Milestone
No milestone
1 participant
@gibbz00